Control: tags -1 +moreinfo Philipp,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: W: turtle source: inconsistent-appstream-metadata-license data/de.philippun1.turtle.metainfo.xml (cc0-1.0 != gpl-3+) [debian/copyright] N: N: The specified AppStream metadata file specifies a metadata_license field N: but this does not match its entry (possibly via the Files: * stanza) in N: debian/copyright. N: N: Please refer to https://wiki.debian.org/AppStream/Guidelines, N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, and N: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/copyright/dep5 N: N: W: python3-turtlevcs: initial-upload-closes-no-bugs [usr/share/doc/python3- turtlevcs/changelog.Debian.gz:1] N: N: This package appears to be the first packaging of a new upstream software N: package (there is only one changelog entry and the Debian revision is 1), N: but it does not close any bugs. The initial upload of a new package should N: close the corresponding ITP bug for that package. N: N: This warning can be ignored if the package is not intended for Debian or N: if it is a split of an existing Debian package. N: N: Please refer to New packages (Section 5.1) in the Debian Developer's N: Reference for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/changelog N: Renamed from: new-package-should-close-itp-bug N: N: W: turtle-cli: initial-upload-closes-no-bugs [usr/share/doc/turtle- cli/changelog.Debian.gz:1] N: W: turtle-nautilus: initial-upload-closes-no-bugs [usr/share/doc/turtle- nautilus/changelog.Debian.gz:1] N: W: python3-turtlevcs: maintainer-script-ignores-errors [postinst] N: N: The maintainer script doesn't seem to set the -e flag which ensures that N: the script's execution is aborted when any executed command fails. N: N: Please refer to Scripts (Section 10.4) in the Debian Policy Manual for N: details. N: N: Visibility: warning N: Show-Always: no N: Check: scripts N: N: W: python3-turtlevcs: maintainer-script-ignores-errors [postrm] N: W: turtle-cli: no-manual-page [usr/bin/turtle_cli] N: N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have N: a manual page N: N: Note that though the man program has the capability to check for several N: program names in the NAMES section, each of these programs should have its N: own manual page (a symbolic link to the appropriate manual page is N: sufficient) because other manual page viewers such as xman or tkman don't N: support this. N: N: If the name of the manual page differs from the binary by case, man may be N: able to find it anyway; however, it is still best practice to match the N: exact capitalization of the executable in the manual page. N: N: If the manual pages are provided by another package on which this package N: depends, Lintian may not be able to determine that manual pages are N: available. In this case, after confirming that all binaries do have manual N: pages after this package and its dependencies are installed, please add a N: Lintian override. N: N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: binary-without-manpage N: N: W: turtle-cli: no-manual-page [usr/bin/turtle_service] N: I: python3-turtlevcs: extended-description-is-probably-too-short N: N: The extended description (the lines after the first line of the N: "Description:" field) is only one or two lines long. The extended N: description should provide a user with enough information to decide N: whether they want to install this package, what it contains, and how it N: compares to similar packages. One or two lines is normally not enough to N: do this. N: N: Please refer to General guidelines for package descriptions (Section N: 6.2.1) in the Debian Developer's Reference and The long description N: (Section 6.2.3) in the Debian Developer's Reference for details. N: N: Visibility: info N: Show-Always: no N: Check: fields/description N: N: I: turtle-cli: extended-description-is-probably-too-short N: I: turtle-nautilus: extended-description-is-probably-too-short N: I: turtle source: installable-field-mirrors-source (in section for turtle-cli) Section [debian/control:36] N: N: The named field for an installation package in debian/control has the same N: value as the one inherited from the source paragraph. N: N: In the interest of shorter and clearer files, you may wish to take N: advantage of the inheritance rules. This field is redundant. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/redundant N: Renamed from: binary-control-field-duplicates-source N: N: I: turtle source: installable-field-mirrors-source (in section for turtle- nautilus) Section [debian/control:46] N: I: python3-turtlevcs: wrong-section-according-to-package-name vcs => python N: N: This package has a name suggesting that it belongs to a section other than N: the one it is currently categorized in. N: N: Visibility: info N: Show-Always: no N: Check: fields/section N: N: P: python3-turtlevcs: repeated-path-segment dialogs [usr/lib/python3/dist- packages/turtlevcs/dialogs/ui/dialogs/] N: N: The file is installed into a location that repeats the given path segment. N: An example would be /usr/lib/lib or /usr/share/myprogram/share. N: N: More often than not this is unintended. N: N: Please refer to Bug#950052 and Bug#950027 for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: files/hierarchy/path-segments N: N: N: masked by screen python/egg/metadata M: python3-turtlevcs: package-contains-documentation-outside-usr-share-doc [usr/lib/python3/dist-packages/turtlevcs-0.11.egg-info/dependency_links.txt] N: N: This package ships a documentation file outside /usr/share/doc N: Documentation files are normally installed inside /usr/share/doc. N: N: If this file doesn't describe the contents or purpose of the directory it N: is in, please consider moving this file to /usr/share/doc/ or maybe even N: removing it. If this file does describe the contents or purpose of the N: directory it is in, please add a lintian override. N: N: Visibility: info N: Show-Always: no N: Check: documentation N: N: Screen: python/egg/metadata N: Advocates: "Scott Kitterman" <deb...@kitterman.com> N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for N: Python modules. Those files are not documentation even though N: some of their names carry the .txt file extension. N: N: Python modules can be both public and private. N: N: Read more in N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory, N: https://www.python.org/dev/peps/pep-0376/#id16, N: https://www.python.org/dev/peps/pep-0610/, N: https://www.python.org/dev/peps/pep-0639/, N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html, N: and Bug#1003913. N: N: N: masked by screen python/egg/metadata M: python3-turtlevcs: package-contains-documentation-outside-usr-share-doc [usr/lib/python3/dist-packages/turtlevcs-0.11.egg-info/requires.txt] N: N: masked by screen python/egg/metadata M: python3-turtlevcs: package-contains-documentation-outside-usr-share-doc [usr/lib/python3/dist-packages/turtlevcs-0.11.egg-info/top_level.txt] E: Lintian run failed (runtime error) 3. Licenses [4]: See 2. 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time. Additonal... A. 'd/changelog' entry should be closing an ITP bug for new package. Summary... I believe turtle is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Please try the below on your packages... [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'
