Control: tags -1 +confirmed John,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only W: midiminder: groff-message an.tmac:<standard input>:101: warning: tbl preprocessor failed, or it or soelim was not run; table(s) likely not rendered (TE macro called with TW register undefined) [usr/share/man/man1/midiwala.1.gz:1] N: N: A manual page provoked warnings or errors from the man program. Here are N: some common ones: N: N: "cannot adjust" or "can't break" are issues with paragraph filling. They N: are usually related to long lines. Justifying text on the left hand side N: can help with adjustments. Hyphenation can help with breaks. N: N: For more information, please see "Manipulating Filling and Adjusting" and N: "Manipulating Hyphenation" in the Groff manual (see info groff). N: N: "can't find numbered character" usually means that the input was in a N: national legacy encoding. The warning means that some characters were N: dropped. Please use escapes such as \[:a] as described on the groff_char N: manual page. N: N: Other common warnings are formatting typos. String arguments to .IP N: require quotes. Usually, some text is lost or mangled. See the groff_man N: (or groff_mdoc if using mdoc) manual page for details on macros. N: N: The check for manual pages uses the --warnings option to man to catch N: common problems, like a . or a ' at the beginning of a line as literal N: text. They are interpreted as Groff commands. Just reformat the paragraph N: so the characters are not at the beginning of a line. You can also add a N: zero-width space (\&) in front of them. N: N: Aside from overrides, warnings can be disabled with the .warn directive. N: Please see "Debugging" in the Groff manual. N: N: You can see the warnings yourself by running the command used by Lintian: N: N: LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \ N: man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null N: N: Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual N: page for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-has-errors-from-man N: N: W: midiminder: groff-message an.tmac:<standard input>:125: warning: tbl preprocessor failed, or it or soelim was not run; table(s) likely not rendered (TE macro called with TW register undefined) [usr/share/man/man5/midiminder- profile.5.gz:1] 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... I believe midiminder is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. Please try the below on your packages... [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'
