Control: tags -1 +confirmed
Nicola,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Additional...
A. For a future upload, can you make the 'd/pristine-tar.sh' dealing with
binaries called i.e. 'curl'. Check if it is installed and tell user more
elegantly if it is not and they need to install it.
Example...
# Check we have curl installed and available for use.
if ! [ -x "$(command -v curl)" ]
then
printf "\n=== CRITICAL ===\n"
printf "\n'curl' could not be found.\n"
printf "\nPlease check you have 'curl' installed on your system.\n"
printf "\nUnable to continue, exiting.\n\n"
exit
fi
Above is just an example of similar to how I do it in bash scripts.
Summary...
I believe uacme is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready.
Please try the below on your packages...
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'
