Control: tags -1 +moreinfo Xiyue,
Merry Christmas mate.
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 14: We
N:
N: You should avoid the use of first person ("I will do this..." or "We
N: recommend..."). The computer is not a person and the description does not
N: speak for the maintainer or maintainers. Instead, use a more neutral
N: construction and try to rephrase into factual statements about the
N: package.
N:
N: For example, rather than saying "I don't recommend this package if you are
N: short on memory," say something like "this package is not suitable for
N: low-memory systems."
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
N:
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 15: our
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 16: We
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 18: We
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 20: we
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 22: We
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 24: We
N:
N: Upstream description uses first person tone.
O: elpa-tp: using-first-person-in-description line 25: We
I: Lintian run was successful.
We can fix this and not override can't we?
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe tp-el is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
Donations...
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Liberapay: https://liberapay.com/kathenas
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Wiki: https://wiki.kathenas.org
Instagram: https://instagram.com/kathenasorg
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
