Control: tags -1 +confirmed
Lorenzo,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only, none blocking
Running lintian...
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/cs/man1/mplayer.1.gz:6551]
N:
N: This manual page uses the \' groff sequence. Usually, the intent is to
N: generate an apostrophe, but that sequence actually renders as an acute
N: accent.
N:
N: For an apostrophe or a single closing quote, use plain '. For single
N: opening quote, i.e. a straight downward line ' like the one used in shell
N: commands, use '\(aq'.
N:
N: In case this tag was emitted for the second half of a '\\' sequence, this
N: is indeed no acute accent, but still wrong: A literal backslash should be
N: written \e in the groff format, i.e. a '\\' sequence needs to be changed
N: to '\e' which also won't trigger this tag.
N:
N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: acute-accent-in-manpage
N:
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:1885]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:2911]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:510]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:5820]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:5821]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:5823]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:5825]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/de/man1/mplayer.1.gz:5857]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:1012]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:5875]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:5876]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:5877]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:5879]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/fr/man1/mplayer.1.gz:5909]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:2710]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:499]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:5790]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:5791]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:5793]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:5795]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/hu/man1/mplayer.1.gz:5826]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:3029]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6294]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6295]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6296]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6298]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6330]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/it/man1/mplayer.1.gz:6331]
N:
I: mplayer: acute-accent-in-manual-page [usr/share/man/man1/mplayer.1.gz:6125]
N:
I: mplayer: acute-accent-in-manual-page [usr/share/man/man1/mplayer.1.gz:6126]
N:
I: mplayer: acute-accent-in-manual-page [usr/share/man/man1/mplayer.1.gz:6127]
N:
I: mplayer: acute-accent-in-manual-page [usr/share/man/man1/mplayer.1.gz:6129]
N:
I: mplayer: acute-accent-in-manual-page [usr/share/man/man1/mplayer.1.gz:6161]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/ru/man1/mplayer.1.gz:5535]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/ru/man1/mplayer.1.gz:5536]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/ru/man1/mplayer.1.gz:5537]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/ru/man1/mplayer.1.gz:5539]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/ru/man1/mplayer.1.gz:5572]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6154]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6155]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6156]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6158]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6190]
N:
I: mplayer: acute-accent-in-manual-page
[usr/share/man/zh_CN/man1/mplayer.1.gz:6191]
N:
I: mplayer: bash-term-in-posix-shell 's/[]()|'
[usr/share/mplayer/midentify.sh:17]
N:
N: This script is marked as running under /bin/sh, but it seems to use a
N: feature found in bash but not in the SUSv3 or POSIX shell specification.
N:
N: Some examples are:
N:
N: - == in a test, it should use = instead - read without a variable in the
N: argument - function to define a function - source instead of . - . command
N: args, passing arguments to commands via source is not supported -
N: {foo,bar} instead of foo bar - [[ test ]] instead of [ test ] (requires a
N: Korn shell) - type instead of which or command -v
N:
N: Visibility: info
N: Show-Always: no
N: Check: shell/non-posix/bash-centric
N:
N:
I: mencoder: file-references-package-build-path [usr/bin/mencoder]
N:
N: The listed file or maintainer script appears to reference the build path
N: used to build the package as specified in the Build-Path field of the
N: .buildinfo file.
N:
N: This is likely to cause the package to be unreproducible, but it may also
N: indicate that the package will not work correctly outside of the
N: maintainer's own system.
N:
N: Please note that this tag will not appear unless the .buildinfo file
N: contains a Build-Path field. That field is optional. You may have to set
N: DEB_BUILD_OPTIONS=buildinfo=+path or use
N: --buildinfo-option=--always-include-path with dpkg-buildpackage when
N: building.
N:
N: Please refer to https://reproducible-builds.org/,
N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the
N: dpkg-genbuildinfo(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/contents
N:
N:
I: mplayer: file-references-package-build-path [usr/bin/mplayer]
N:
I: mplayer-gui: file-references-package-build-path [usr/bin/gmplayer]
N:
I: mplayer source: quilt-patch-missing-description [debian/patches/0209-gcc14-
fix-build-powerpc-bigen.patch]
N:
N: quilt patch files should start with a description of patch. All lines
N: before the start of the patch itself are considered part of the
N: description. You can edit the description with quilt header -e when the
N: patch is at the top of the stack.
N:
N: As well as a description of the purpose and function of the patch, the
N: description should ideally contain author information, a URL for the bug
N: report (if any), Debian or upstream bugs fixed by it, upstream status, the
N: Debian version and date the patch was first included, and any other
N: information that would be useful if someone were investigating the patch
N: and underlying problem. Please consider using the DEP 3 format for this
N: information.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/quilt
N:
N:
I: mplayer source: repackaged-source-not-advertised [debian/copyright]
N:
N: The debian/copyright file mentions Files-Excluded but the source version
N: has no repack suffix.
N:
N: Repackaged sources are expected to indicate in their version number that
N: they are different from the upstream release. It is commonly done by
N: adding a repack suffix to the upstream version.
N:
N: The choice of repack suffix depends on the reason for repackaging. When
N: some files were excluded because licensing was a concern, the suffix +dfsg
N: may be appropriate. In more generic cases, one could chose +ds.
N:
N: Upstream sources are sometimes repackaged by accident when using old
N: versions of dh_make. It can also happen when a maintainer invokes the
N: dh_make option --createorig even though it is not needed.
N:
N: According to the Debian Developer's Reference 6.7.8.2, the repack suffix
N: is not required.
N:
N: Please include such a suffix in the changelog version number to avoid this
N: warning.
N:
N: Please refer to Bug#471537 and
N:
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html
N: for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
I: mencoder: spelling-error-in-binary Expexct Expect [usr/bin/mencoder]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: mplayer: spelling-error-in-binary Expexct Expect [usr/bin/mplayer]
N:
I: mplayer: spelling-error-in-binary Syncronous Synchronous [usr/bin/mplayer]
N:
I: mplayer: spelling-error-in-binary configration configuration
[usr/bin/mplayer]
N:
I: mplayer-gui: spelling-error-in-binary Expexct Expect [usr/bin/gmplayer]
N:
I: mplayer-gui: spelling-error-in-binary Syncronous Synchronous
[usr/bin/gmplayer]
N:
I: mplayer-gui: spelling-error-in-binary configration configuration
[usr/bin/gmplayer]
N:
I: mplayer: typo-in-manual-page chosing choosing
[usr/share/man/man1/mplayer.1.gz:11447]
N:
N: Lintian found a spelling error in a manual page. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext (with the help of po4a, for example) or a similar tool, please fix
N: the error in the translations as well as the English text to avoid making
N: the translations fuzzy. With gettext, for example, this means you should
N: also fix the spelling mistake in the corresponding msgids in the *.po
N: files.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: spelling-error-in-manpage
N:
N:
I: mplayer: typo-in-manual-page delimeters delimiters
[usr/share/man/man1/mplayer.1.gz:11523]
N:
I: mplayer: typo-in-manual-page noticably noticeably
[usr/share/man/man1/mplayer.1.gz:8975]
N:
I: mplayer: typo-in-manual-page performace performance
[usr/share/man/man1/mplayer.1.gz:6183]
N:
I: mplayer: typo-in-manual-page substract subtract
[usr/share/man/man1/mplayer.1.gz:1014]
I: Lintian run was successful.
I would hope time can be made to look at a few of these over coming uploads
