Control: tags -1 +moreinfo Don,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue, possible false positives Running lintian... N: I: libwf-utils0t64: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/libwf-utils.so.0.4.0] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: wayfire: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/wayfire/libdefault-config-backend.so] N: I: libwf-utils0t64: no-symbols-control-file usr/lib/x86_64-linux-gnu/libwf- utils.so.0.4.0 N: N: Although the package includes a shared library, the package does not have N: a symbols control file. N: N: dpkg can use symbols files in order to generate more accurate library N: dependencies for applications, based on the symbols from the library that N: are actually used by the application. N: N: Please refer to the dpkg-gensymbols(1) manual page and N: https://wiki.debian.org/UsingSymbolsFiles for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/shlibs N: N: I: wayfire: no-symbols-control-file usr/lib/x86_64-linux-gnu/libwayfire-blur- base.so N: I: wayfire: typo-in-manual-page incase in case [usr/share/man/man1/wayfire.1.gz:96] N: N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext (with the help of po4a, for example) or a similar tool, please fix N: the error in the translations as well as the English text to avoid making N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po N: files. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: spelling-error-in-manpage N: N: I: libwf-utils0t64: unused-override package-name-doesnt-match-sonames [usr/share/lintian/overrides/libwf-utils0t64:1] N: N: Your package specifies the named override but there were no tags that N: could have been silenced by it. N: N: Maybe you fixed an underlying condition but forgot to remove the override. N: It is also possible that the Lintian maintainers fixed a false positive. N: N: If the override is now unused, please remove it. N: N: This tag is similar to mismatched-override except there a tag could have N: been silenced if the context had matched. N: N: Sometimes, overrides end up not being used because a tag appears only on N: some architectures. In that case, overrides can be equipped with an N: architecture qualifier. N: N: Please refer to Architecture specific overrides (Section 2.4.3) in the N: Lintian User's Manual for details. N: N: Visibility: info N: Show-Always: yes N: Check: lintian N: N: I: libwf-touch-dev: wrong-section-according-to-package-name x11 => libdevel N: N: This package has a name suggesting that it belongs to a section other than N: the one it is currently categorized in. N: N: Visibility: info N: Show-Always: no N: Check: fields/section N: N: I: libwf-utils-dev: wrong-section-according-to-package-name x11 => libdevel N: I: libwf-utils0t64: wrong-section-according-to-package-name x11 => libs N: O: wayfire-dev: national-encoding [usr/include/wayfire/nonstd/observer_ptr.h] N: N: A file is not valid UTF-8. N: N: Debian has used UTF-8 for many years. Support for national encodings is N: being phased out. This file probably appears to users in mangled N: characters (also called mojibake). N: N: Packaging control files must be encoded in valid UTF-8. N: N: Please convert the file to UTF-8 using iconv or a similar tool. N: N: Visibility: warning N: Show-Always: no N: Check: files/encoding N: Renamed from: national-encoding-in-text-file N: debian-changelog-file-uses-obsolete-national-encoding N: debian-control-file-uses-obsolete-national-encoding N: debian-copyright-file-uses-obsolete-national-encoding N: debian-news-file-uses-obsolete-national-encoding N: debian-tests-control-uses-national-encoding N: doc-base-file-uses-obsolete-national-encoding N: national-encoding-in-debconf-template national-encoding-in-manpage N: N: O: wayfire: package-name-doesnt-match-sonames libwayfire-blur-base N: N: The package name of a library package should usually reflect the soname of N: the included library. The package name can determined from the library N: file name with the following code snippet: N: N: $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n - e's/^[[:space:]]*SONAME[[:space:]]*//p' | \ N: sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/' N: N: Visibility: warning N: Show-Always: no N: Check: libraries/shared/soname N: N: O: wayfire: shared-library-lacks-version usr/lib/x86_64-linux-gnu/libwayfire- blur-base.so libwayfire-blur-base.so N: N: The listed shared library in a public library directory has an SONAME that N: does not contain any versioning information, either after the .so or N: before it and set off by a hyphen. It cannot therefore be represented in N: the shlibs system, and if linked by binaries its interface cannot safely N: change. There is no backward-compatible way to migrate programs linked N: against it to a new ABI. N: N: Normally, this means the shared library is a private library for a N: particular application and is not meant for general use. Policy recommends N: that such libraries be installed in a subdirectory of /usr/lib rather than N: in a public shared library directory. N: N: To view the SONAME of a shared library, run readelf -d on the shared N: library and look for the tag of type SONAME. N: N: There are some special stub libraries or special-purpose shared objects N: for which an ABI version is not meaningful. If this is one of those cases, N: please add an override. N: N: Please refer to Libraries (Section 10.2) in the Debian Policy Manual and N: Dependencies between the library and other packages (Section 8.6) in the N: Debian Policy Manual for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/shlibs N: Renamed from: shlib-without-versioned-soname N: I: Lintian run was successful. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue dpkg-source -b . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: building wayfire using existing ./wayfire_0.9.0.orig.tar.gz dpkg-source: info: using patch list from debian/patches/series dpkg-source: info: local changes detected, the modified files are: wayfire-0.9.0/subprojects/wf-touch/LICENSE wayfire-0.9.0/subprojects/wf-touch/README.md wayfire-0.9.0/subprojects/wf-touch/meson.build wayfire-0.9.0/subprojects/wf-touch/meson_options.txt wayfire-0.9.0/subprojects/wf-touch/src/actions.cpp wayfire-0.9.0/subprojects/wf-touch/src/math.cpp wayfire-0.9.0/subprojects/wf-touch/src/touch.cpp wayfire-0.9.0/subprojects/wf-touch/test/action_test.cpp wayfire-0.9.0/subprojects/wf-touch/test/basic_test.cpp wayfire-0.9.0/subprojects/wf-touch/test/gesture_test.cpp wayfire-0.9.0/subprojects/wf-touch/test/meson.build wayfire-0.9.0/subprojects/wf-touch/test/shared.hpp wayfire-0.9.0/subprojects/wf-touch/wayfire/touch/touch.hpp wayfire-0.9.0/subprojects/wf-utils/Doxyfile.in wayfire-0.9.0/subprojects/wf-utils/LICENSE wayfire-0.9.0/subprojects/wf-utils/Makefile wayfire-0.9.0/subprojects/wf-utils/README.md wayfire-0.9.0/subprojects/wf-utils/main.cpp wayfire-0.9.0/subprojects/wf-utils/meson.build wayfire-0.9.0/subprojects/wf-utils/wayfire/action/action.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/action/action.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/action/action_interface.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/access_interface.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/condition.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/condition.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/logic_condition.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/logic_condition.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/test_condition.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/condition/test_condition.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/lexer.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/lexer.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/literal.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/literal.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/symbol.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/lexer/symbol.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/action_parser.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/action_parser.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/condition_parser.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/condition_parser.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/lambda_rule_parser.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/lambda_rule_parser.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/rule_parser.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/parser/rule_parser.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/rule/lambda_rule.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/rule/lambda_rule.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/rule/rule.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/rule/rule.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/utils.hpp wayfire-0.9.0/subprojects/wf-utils/wayfire/variant.cpp wayfire-0.9.0/subprojects/wf-utils/wayfire/variant.hpp wayfire-0.9.0/subprojects/wf-utils/wf-utils.pro dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree dpkg-source: info: you can integrate the local changes with dpkg-source -- commit dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/wayfire_0.9.0-5.diff.4M4Cj7 dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package 6. Reproducible builds [5]: Not performed at this time 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Summary... I believe wayfire is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Wiki: https://wiki.kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
