Control: tags -1 +moreinfo <REPLACE_WITH_SUBMITTER>,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: W: meshlab: possible-unindented-list-in-extended-description line 13 N: N: The package "Description:" contains an unindented line which starts with a N: dash (-) or asterisk (*). If this was meant to be a list of items these N: lines need to be indented (dselect would word-wrap these lines otherwise). N: N: Please refer to Description (Section 5.6.13) in the Debian Policy Manual N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: fields/description N: N: I: meshlab source: anticipated-repack-count 2022.02+dfsg1-1 N: N: The version contains the string +dfsgN where N is a low number as in N: +dfsg1. N: N: Normally it is not necessary to repackage an upstream source package more N: than once. You can omit the repack count. In most cases +dfsg-1 is enough. N: N: If you really need to bump it, just go straight to +dfsg2-1. N: N: Please refer to N: https://lists.debian.org/debian-devel/2021/10/msg00026.html for details. N: N: Visibility: info N: Show-Always: no N: Check: fields/version/repack/count N: N: I: meshlab: desktop-entry-lacks-keywords-entry [usr/share/applications/meshlab.desktop] N: N: This .desktop file is either missing a Keywords entry, or it does not N: contain keywords above and beyond those already present in the Name or N: GenericName entries. N: N: The Keywords field is intended to show keywords relevant for a .desktop N: file. N: N: Desktop files are organized in key-value pairs and are similar to INI N: files. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html, N: Bug#693918, and N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for N: details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format N: N: I: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/meshlab/plugins/libio_e57.so] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/0008-e57-Fix- build-error-from-missing-include.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/0008-u3d-Use- system-zlib-jpeg-png.patch] N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/0009-Fix- spelling-errors-in-strings.patch] N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/06_format- security.patch] N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/18_structuresynth_license.patch] N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/22_find- plugins.patch] N: I: meshlab source: patch-not-forwarded-upstream [debian/patches/27_Remove-more- __date__-usages.patch] N: I: meshlab: spelling-error-in-binary ment meant [usr/lib/x86_64-linux- gnu/meshlab/plugins/librender_radiance_scaling.so] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/IDTF/IFXResource.h] N: N: The following file is autogenerated by Microsoft Visual C++. N: N: They are usually provided for the convenience of users. These files N: usually just take up space in the tarball and are of no use in Debian. N: N: Check if upstream also provides source-only tarballs that you can use as N: the upstream distribution instead. If not, you may want to ask upstream to N: provide source-only tarballs. N: N: Visibility: pedantic N: Show-Always: no N: Check: cruft N: N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXCore/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXExporting/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXImporting/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXRendering/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXScheduling/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXShapes/IFXResource.h] N: P: meshlab source: source-contains-autogenerated-visual-c++-file [src/external/u3d/src/RTL/Platform/Win32/IFXTextureModifier/IFXResource.h] N: N: Not sure why only these two get the warning, but all are built with the N: same flags, so considering these false-positives. O: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/meshlab/libmeshlab-common.so] N: N: Not sure why only these two get the warning, but all are built with the N: same flags, so considering these false-positives. O: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/meshlab/plugins/librender_gdp.so] N: N: Relative rpath fixes reproducible builds, needed to find private library
