Control: tags -1 -confimed
Control: tags -1 +moreinfo

Thomas,

New version, updated review.

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

Note: SOme DD's may wish you to add a 'Files: debian/*' section.

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. autopkgtests

System information on Sat Dec 14 07:43:41 UTC 2024

 <πŸ˜€========================================================================πŸ˜€>
         #     #                                                   ###
         #  #  #  ######  #        ####    ####   #    #  ######   ###
         #  #  #  #       #       #    #  #    #  ##  ##  #        ###
         #  #  #  #####   #       #       #    #  # ## #  #####     # 
         #  #  #  #       #       #       #    #  #    #  #           
         #  #  #  #       #       #    #  #    #  #    #  #        ###
          ## ##   ######  ######   ####    ####   #    #  ######   ###
                                        
               You can change this banner in /etc/system-info.d!
 <πŸ˜€========================================================================πŸ˜€>


Host:               ks-tarkin
Uptime:             0 days, 4 hours, 42 minutes, and 57 seconds
Operating System:   Debian GNU/Linux Unknown (trixie) with kernel 6.11.10-amd64
Processor:          12 Γ— x86_64; 15 processes; 0 users
Load (1/5/15 min):  8.7 % / 6.8 % / 3.4 %
Used Memory:          1095 MiB of   7926 MiB (  6831 MiB available:  86.2 %)
Used Swap:              20 MiB of   5285 MiB (  5265 MiB available:  99.6 %)
Used Diskspace:     9 % on /, 9 % on /home, 9 % on /tmp
Network:            
   enp1s0:          192.168.122.42 / 24
Test passed!
autopkgtest [07:43:41]: test 51-system-info-i18n: -----------------------]
autopkgtest [07:43:41]: test 51-system-info-i18n:  - - - - - - - - - - results
- - - - - - - - - -
51-system-info-i18n  PASS
autopkgtest [07:43:41]: @@@@@@@@@@@@@@@@@@@@ summary
10-print-utf8        PASS
20-get-system-info   PASS
30-system-maintenance PASS
31-reset-machine-id  FAIL non-zero exit status 1
40-fingerprint-ssh-keys PASS
41-misc              PASS
50-system-info-run   PASS
51-system-info-i18n  PASS

E: Autopkgtest run failed.

Summary...

I believe td-system-tools is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Wiki: https://wiki.kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--












Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to