Thomas, I will do an updated basic review here for your information.
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: E: rsplib-registrar: aliased-location [lib/] N: N: This package installs files into an aliased location and should not be N: doing so. N: N: Since Debian Trixie, the base-files package sets up symbolic links such as N: /bin pointing to usr/bin. Installing files in /bin directly thus triggers N: undefined behaviour in dpkg. N: N: Packages must no longer install files into such locations and must install N: them to the corresponding location under usr/ instead. N: N: Please refer to Binaries (Section 10.1) in the Debian Policy Manual and N: Bug#1074014 for details. N: N: Visibility: error N: Show-Always: no N: Check: files/hierarchy/standard N: N: E: rsplib-registrar: aliased-location [lib/systemd/] N: E: rsplib-registrar: aliased-location [lib/systemd/system/] N: E: rsplib-registrar: aliased-location [lib/systemd/system/rspregistrar.service] N: I: libcpprspserver3t64: unused-override package-name-doesnt-match-sonames [usr/share/lintian/overrides/libcpprspserver3t64:2] N: N: Your package specifies the named override but there were no tags that N: could have been silenced by it. N: N: Maybe you fixed an underlying condition but forgot to remove the override. N: It is also possible that the Lintian maintainers fixed a false positive. N: N: If the override is now unused, please remove it. N: N: This tag is similar to mismatched-override except there a tag could have N: been silenced if the context had matched. N: N: Sometimes, overrides end up not being used because a tag appears only on N: some architectures. In that case, overrides can be equipped with an N: architecture qualifier. N: N: Please refer to Architecture specific overrides (Section 2.4.3) in the N: Lintian User's Manual for details. N: N: Visibility: info N: Show-Always: yes N: Check: lintian N: N: I: librsplib3t64: unused-override package-name-doesnt-match-sonames [usr/share/lintian/overrides/librsplib3t64:4] N: N: Package is built with -D_FORTIFY_SOURCE=2, so this is a false positive: O: librsplib3t64: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/libtdrandomizer.so.3.4.10] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: E: Lintian run failed (runtime error) 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Summary... Please review and note previous entries on this bug. I believe rsplib is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Wiki: https://wiki.kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
