Control: tags -1 +moreinfo Don,
Early review. Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information Running lintian... N: I: lightspark: desktop-entry-lacks-keywords-entry [usr/share/applications/lightspark.desktop] N: N: This .desktop file is either missing a Keywords entry, or it does not N: contain keywords above and beyond those already present in the Name or N: GenericName entries. N: N: The Keywords field is intended to show keywords relevant for a .desktop N: file. N: N: Desktop files are organized in key-value pairs and are similar to INI N: files. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html, N: Bug#693918, and N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for N: details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format N: N: I: lightspark: spelling-error-in-binary implemeted implemented [usr/lib/lightspark/liblightspark.so.0.8.7] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: lightspark source: vcs-field-not-canonical Git https://salsa.debian.org/EiPiFun/lightspark https://salsa.debian.org/EiPiFun/lightspark.git N: N: The VCS-* field contains an uncanonical URI. Please update to use the N: current canonical URI instead. This reduces the network bandwidth used and N: makes debcheckout work independent of the port forwarding and redirections N: properly working. N: N: Note that this check is based on a list of known URIs. Lintian did not N: send an HTTP request to the URI to test this. N: N: Visibility: info N: Show-Always: no N: Check: fields/vcs N: N: P: lightspark source: package-does-not-install-examples [src/3rdparty/imgui/examples/] N: N: The original source tarball contains the specified examples directory. N: However, no examples are installed in any binary packages. N: N: Please use dh_installexamples to install these to the most relevant N: package, for example by adding the directory name followed by a wildcard N: to a debian/pkgname.examples file. N: N: Lintian looks for any directory called examples under /usr/share/doc in N: all binary packages. N: N: Please refer to the dh_installexamples(1) manual page for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: examples N: N: Screen: examples/in-tests N: Advocates: "Scott Kitterman" <deb...@kitterman.com> N: Reason: N: Some sources like python-tomlkit trigger this tag for tests because of files N: in ./tests/examples/. They are not examples for tomlkit, however. They are N: examples of TOML files used in the tests. N: N: Overall, the check is probably better off not looking in test N: directories. N: N: Read more in Bug#1005184. N: N: O: lightspark: desktop-entry-invalid-category Multimedia [usr/share/applications/lightspark.desktop] N: N: This desktop entry shows a category that is not among the registered N: "main" or "additional" categories in the FreeDesktop specification. N: N: The values are case-sensitive. Whitespace is only allowed just before and N: after the equals sign in the Category key, and nowhere else. N: N: The desktop-file-validate tool in the desktop-file-utils package is useful N: when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/menu-spec/latest/apa.html for N: details. N: N: Visibility: warning N: Show-Always: no N: Check: menu-format N: N: O: lightspark: desktop-mime-but-no-exec-code [usr/share/applications/lightspark.desktop] N: N: The named desktop entry indicates support for at least one MIME type, but N: does not provide a code like %f, %F, %u or %U in the Exec key. N: N: If the application can in fact handle files of the given MIME types, the N: menu item should somehow pass those filenames as parameters to the N: executable. N: N: Visibility: warning N: Show-Always: no N: Check: menu-format N: N: O: lightspark: library-not-linked-against-libc [usr/lib/lightspark/libCore.so] N: N: The package installs a library which is not dynamically linked against N: libc. N: N: It is theoretically possible to have a library which doesn't use any N: symbols from libc, but it is far more likely that this is a violation of N: the requirement that "shared libraries must be linked against all N: libraries that they use symbols from in the same way that binaries are". N: N: Please refer to Libraries (Section 10.2) in the Debian Policy Manual and N: Bug#698720 for details. N: N: Visibility: error N: Show-Always: no N: Check: binaries/prerequisites N: N: O: lightspark: package-has-unnecessary-activation-of-ldconfig-trigger N: N: The package activates the ldconfig trigger even though no shared libraries N: are installed in a directory controlled by the dynamic library loader. N: N: Note this may be triggered by a bug in debhelper, that causes it to N: auto-generate an ldconfig trigger for packages that do not need it. N: N: Please refer to ldconfig (Section 8.1.1) in the Debian Policy Manual and N: Bug#204975 for details. N: N: Visibility: warning N: Show-Always: no N: Check: libraries/shared/trigger/ldconfig N: I: Lintian run was successful. 3. Licenses [4]: Issue, possiblr false positives philwyett@ks-tarkin:~/Development/builder/debian/lightspark- 0.8.7+git.20241203.79371ce$ lrc en: Versions: recon 3.2 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/core/BigInteger.cpp LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/core/BigInteger.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/core/d2a.cpp LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/core/d2a.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/LICENSE LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/config.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/config.h.in LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/dftables.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/LICENCE LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/manifest.mk LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/pcre_avmplus.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/pcre_chartables.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_compile.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_config.cpp LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/pcre-config.in LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcrecpp.cc LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcrecpp.h.in LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcrecpp_unittest.cc LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/pcredemo.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_dfa_exec.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_exec.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_fullinfo.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_get.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_globals.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcregrep.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre.h LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre.h.in LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_info.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_internal.h LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_maketables.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_newline.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_ord2utf8.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcreposix.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcreposix.h LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_printint.src LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_refcount.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_scanner.cc LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_scanner.h LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_scanner_unittest.cc LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_stringpiece.cc LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_stringpiece.h.in LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_study.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_tables.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcretest.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_try_flipped.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_ucp_findchar.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_valid_utf8.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_version.cpp LGPL-3+ | BSD-3-clause src/3rdparty/avmplus/pcre/pcre_xclass.cpp LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/perltest LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/RunGrepTest.in LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/RunTest.in LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/ucp.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/ucpinternal.h LGPL-3+ | MPL-2.0 src/3rdparty/avmplus/pcre/ucptable.cpp LGPL-3+ | Unlicense src/3rdparty/imgui/backends/imgui_impl_opengl3_loader.h LGPL-3+ | OFL-1.1 src/3rdparty/imgui/docs/FONTS.md LGPL-3+ | Zlib src/3rdparty/imgui/examples/libs/glfw/include/GLFW/glfw3.h LGPL-3+ | Zlib src/3rdparty/imgui/examples/libs/glfw/include/GLFW/glfw3native.h LGPL-3+ | Zlib src/3rdparty/imgui/examples/libs/usynergy/uSynergy.c LGPL-3+ | Zlib src/3rdparty/imgui/examples/libs/usynergy/uSynergy.h LGPL-3+ | CECILL-C src/3rdparty/imgui/imconfig.h LGPL-3+ | Expat and/or Unlicense src/3rdparty/imgui/imstb_rectpack.h LGPL-3+ | Expat and/or Unlicense src/3rdparty/imgui/imstb_textedit.h LGPL-3+ | Expat and/or Unlicense src/3rdparty/imgui/imstb_truetype.h LGPL-3+ | Expat src/3rdparty/imgui/LICENSE.txt LGPL-3+ | OFL-1.0 src/3rdparty/imgui/misc/fonts/Cousine- Regular.ttf LGPL-3+ | OFL-1.1 src/3rdparty/imgui/misc/fonts/Karla- Regular.ttf LGPL-3+ | CECILL-C src/3rdparty/imgui/misc/freetype/imgui_freetype.cpp LGPL-3+ | Zlib src/3rdparty/nanovg/example/example_fbo.c LGPL-3+ | Zlib src/3rdparty/nanovg/example/example_gl2.c LGPL-3+ | Zlib src/3rdparty/nanovg/example/example_gl3.c LGPL-3+ | Zlib src/3rdparty/nanovg/example/example_gles2.c LGPL-3+ | Zlib src/3rdparty/nanovg/example/example_gles3.c LGPL-3+ | OFL-1.1 src/3rdparty/nanovg/example/LICENSE_OFL.txt LGPL-3+ | Zlib src/3rdparty/nanovg/LICENSE.txt LGPL-3+ | Zlib src/3rdparty/nanovg/obsolete/nanovg_gl2.h LGPL-3+ | Zlib src/3rdparty/nanovg/obsolete/nanovg_gl3.h LGPL-3+ | Zlib src/3rdparty/nanovg/src/fontstash.h LGPL-3+ | Zlib src/3rdparty/nanovg/src/nanovg.c LGPL-3+ | Zlib src/3rdparty/nanovg/src/nanovg_gl.h LGPL-3+ | Zlib src/3rdparty/nanovg/src/nanovg_gl_utils.h LGPL-3+ | Zlib src/3rdparty/nanovg/src/nanovg.h LGPL-3+ | Expat and/or Unlicense src/3rdparty/nanovg/src/stb_truetype.h LGPL-3+ | Expat src/3rdparty/pugixml/docs/manual.adoc LGPL-3+ | Expat src/3rdparty/pugixml/docs/quickstart.adoc LGPL-3+ | Expat src/3rdparty/pugixml/LICENSE.md LGPL-3+ | Expat src/3rdparty/pugixml/src/pugiconfig.hpp LGPL-3+ | Expat src/3rdparty/pugixml/src/pugixml.cpp LGPL-3+ | Expat src/3rdparty/pugixml/src/pugixml.hpp LGPL-3+ | Zlib src/3rdparty/tinyfiledialogs/hello.c LGPL-3+ | Zlib src/3rdparty/tinyfiledialogs/hello_wchar_t.c LGPL-3+ | Zlib src/3rdparty/tinyfiledialogs/tinyfiledialogs.c LGPL-3+ | Zlib src/3rdparty/tinyfiledialogs/tinyfiledialogs.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/npapi/npapi.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/npapi/npfunctions.h LGPL-3+ | BSD-3-clause src/plugin/include/npapi/npruntime.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/npapi/nptypes.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/npplat.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/npupp.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 src/plugin/include/pluginbase.h LGPL-3+ | Khronos src/plugin_ppapi/KHR/khrplatform.h LGPL-3+ | GPL-2+ and/or GPL-2+ or LGPL-2.1+ and/or MPL-1.1 tests/tamarin-lightspark.as 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: N/A Additional... A. Remove unnecessary versioned 'Build-Depends' in 'debian/control'. B. If the web browser plugin is not/never to be built. Removing references to the browser plugin in package description etc. may be best as some may expect it if not. Advertise as a standalone player only. C. Could an additional section of notes be added to end of next upload with useful links to Flash Games/Applications resource(s) that can be used for testing. Save me searching. ;-) D. '* Build without browser plugin' not really needed in 'debian/changelog'
