Control: tags -1 +moreinfo

Jorg,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

Running lintian...
N:
W: sane-backends source: newer-standards-version 4.7.0.1 (current is 4.7.0)
N: 
N:   The source package refers to a Standards-Version which is newer than the
N:   highest one Lintian is programmed to check.
N:   
N:   If the source package is correct, please upgrade Lintian to the newest
N:   version.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
W: sane-utils: no-manual-page [usr/bin/umax_pp]
N: 
N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N:   a manual page
N:   
N:   Note that though the man program has the capability to check for several
N:   program names in the NAMES section, each of these programs should have its
N:   own manual page (a symbolic link to the appropriate manual page is
N:   sufficient) because other manual page viewers such as xman or tkman don't
N:   support this.
N:   
N:   If the name of the manual page differs from the binary by case, man may be
N:   able to find it anyway; however, it is still best practice to match the
N:   exact capitalization of the executable in the manual page.
N:   
N:   If the manual pages are provided by another package on which this package
N:   depends, Lintian may not be able to determine that manual pages are
N:   available. In this case, after confirming that all binaries do have manual
N:   pages after this package and its dependencies are installed, please add a
N:   Lintian override.
N: 
N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: binary-without-manpage
N: 
N:
I: libsane-common: possible-documentation-but-no-doc-base-registration
N: 
N:   The package ships a .html or .pdf file under /usr/share/doc/. Those files
N:   are usually documentation, but no files are registered in doc-base.
N:   
N:   Files in folders named examples are exempt from this tag.
N: 
N:   Please refer to Registering Documents using doc-base (Section 9.10) in the
N:   Debian Policy Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: menus
N: 
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-artec_eplus48u.so.1.2.1]
N: 
N:   Lintian found a spelling error in the given binary. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help of
N:   gettext or a similar tool, please fix the error in the translations as
N:   well as the English text to avoid making the translations fuzzy. With
N:   gettext, for example, this means you should also fix the spelling mistake
N:   in the corresponding msgids in the *.po files.
N:   
N:   You can often find the word in the source code by running:
N:   
N:    grep -rw <word> <source-tree>
N:   
N:   This tag may produce false positives for words that contain non-ASCII
N:   characters due to limitations in strings.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/spelling
N: 
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-canon_dr.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-gt68xx.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary begining beginning [usr/lib/x86_64-linux-
gnu/sane/libsane-lexmark_x2600.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary posible possible [usr/lib/x86_64-linux-
gnu/sane/libsane-lexmark_x2600.so.1.2.1]
N:
I: sane-utils: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/saned@.service]
N: 
N:   The systemd service file does not contain a Documentation key.
N:   
N:   Documentation for systemd service files can be automatically viewed using
N:   systemctl help servicename if this field is present.
N: 
N:   Please refer to the systemd.unit(5) manual page for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: systemd
N: 
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:120]
N: 
N:   Lintian found a spelling error in a manual page. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help of
N:   gettext (with the help of po4a, for example) or a similar tool, please fix
N:   the error in the translations as well as the English text to avoid making
N:   the translations fuzzy. With gettext, for example, this means you should
N:   also fix the spelling mistake in the corresponding msgids in the *.po
N:   files.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: spelling-error-in-manpage
N: 
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:143]
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:76]
N:
P: sane-backends source: license-problem-gfdl-non-official-text invariant part
is: with no invariant sections, with no front-cover texts, and with no back-
cover [po/fr.po]
N: 
N:   The given source file is licensed under GFDL, but using a non-official
N:   text for the "no invariant sections" part.
N:   
N:   Please ask upstream to always use (case insensitive): with no Invariant
N:   Sections, no Front-Cover Texts, and no Back-Cover Texts.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: cruft
N: 
N:
O: libsane1: diversion-for-unknown-file lib/udev/hwdb.d/20-sane.hwdb
[preinst:11]
N: 
N:   The named maintainer script adds a diversion for a file that is not being
N:   provided by this package.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: maintainer-scripts/diversion
N: 
N:
O: libsane1: diversion-for-unknown-file lib/udev/rules.d/60-libsane1.rules
[preinst:14]
N:
O: libsane1: diversion-for-unknown-file lib/udev/rules.d/99-libsane1.rules
[preinst:17]
N:
N: begin-remove-after: released:trixie protective diversion for upgrades of
N: files moved from / to /usr
O: libsane1: systemd-diversion lib/udev/hwdb.d/20-sane.hwdb [preinst:11]
N: 
N:   A diversion is being added for a systemd configuration file. Diversions
N:   must not be used for systemd configuration files. Instead please make use
N:   of the native override/drop-in mechanisms. This applies not only to the
N:   system and service manager, but also to udev, tmpfiles.d, sysusers.d and
N:   other tools from the systemd project. For information on how to use
N:   overrides and drop-ins, consult the apposite tool's documentation.
N: 
N:   Please refer to Maintainer Scripts (Section 3.9) in the Debian Policy
N:   Manual,
N:  
https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Description,
N:   https://www.freedesktop.org/software/systemd/man/systemd-system.conf.html,
N:   https://www.freedesktop.org/software/systemd/man/udev.html#Rules%20Files,
N:  
https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html#Configuration%20Directories%20and%20Precedence
,
N:  
https://www.freedesktop.org/software/systemd/man/modules-load.d.html#Configuration%20Format
,
N:   and
N:  
https://www.freedesktop.org/software/systemd/man/sysusers.d.html#Configuration%20Directories%20and%20Precedence
N:   for details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: maintainer-scripts/diversion
N: 
N:
N: begin-remove-after: released:trixie protective diversion for upgrades of
N: files moved from / to /usr
O: libsane1: systemd-diversion lib/udev/rules.d/60-libsane1.rules [preinst:14]
N:
N: begin-remove-after: released:trixie protective diversion for upgrades of
N: files moved from / to /usr
O: libsane1: systemd-diversion lib/udev/rules.d/99-libsane1.rules [preinst:17]

E: Lintian run failed (runtime error)

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building sane-backends using existing ./sane-
backends_1.3.1.orig.tar.bz2
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: local changes detected, the modified files are:
 sane-backends-1.3.1/.version
 sane-backends-1.3.1/backend/pixma/pixma_sane_options.c
 sane-backends-1.3.1/backend/pixma/pixma_sane_options.h
 sane-backends-1.3.1/m4/libtool.m4
 sane-backends-1.3.1/po/bg.po
 sane-backends-1.3.1/po/ca.po
 sane-backends-1.3.1/po/c...@valencia.po
 sane-backends-1.3.1/po/cs.po
 sane-backends-1.3.1/po/da.po
 sane-backends-1.3.1/po/de.po
 sane-backends-1.3.1/po/e...@boldquot.po
 sane-backends-1.3.1/po/e...@quot.po
 sane-backends-1.3.1/po/en_GB.po
 sane-backends-1.3.1/po/eo.po
 sane-backends-1.3.1/po/es.po
 sane-backends-1.3.1/po/fi.po
 sane-backends-1.3.1/po/fr.po
 sane-backends-1.3.1/po/gl.po
 sane-backends-1.3.1/po/he.po
 sane-backends-1.3.1/po/hu.po
 sane-backends-1.3.1/po/it.po
 sane-backends-1.3.1/po/ja.po
 sane-backends-1.3.1/po/ka.po
 sane-backends-1.3.1/po/nb.po
 sane-backends-1.3.1/po/nl.po
 sane-backends-1.3.1/po/pl.po
 sane-backends-1.3.1/po/pt.po
 sane-backends-1.3.1/po/ru.po
 sane-backends-1.3.1/po/sane-backends.pot
 sane-backends-1.3.1/po/stamp-po
 sane-backends-1.3.1/po/sv.po
 sane-backends-1.3.1/po/uk.po
 sane-backends-1.3.1/po/zh_CN.po
dpkg-source: info: Hint: make sure the version in debian/changelog matches the
unpacked source tree
dpkg-source: info: you can integrate the local changes with dpkg-source --
commit
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/sane-
backends_1.3.1-1.diff.aO38Sm
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe sane-backends is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method


-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Wiki: https://wiki.kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--












Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to