Control: tags -1 +moreinfo Eric,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: W: mimic source: debian-watch-not-mangling-version opts=filenamemangle=s%.*/@ANY_VERSION@%@PACKAGE@- $1.tar.gz%,downloadurlmangle=s%(api.github.com/repos/[^/]+/[^/]+)/git/refs/%$ 1/tarball/refs/%g,searchmode=plain,repacksuffix=+ds https://api.github.com/repos/hack3ric/mimic/git/matching-refs/tags/v https://api.github.com/repos/[^/]+/[^/]+/git/refs/tags/@ANY_VERSION@ [debian/watch:8] N: N: The version of this package contains dfsg, ds, or debian, which normally N: indicates that the upstream source has been repackaged to comply with the N: Debian Free Software Guidelines (or similar reason), but there is no N: version mangling in the debian/watch file. Since the dfsg string is not N: part of the upstream version, the debian/watch file should use the N: dversionmangle option to remove the dfsg before version number comparison. N: N: Please refer to the uscan(1) manual page and https://wiki.debian.org/DEHS N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/watch N: Renamed from: debian-watch-file-should-mangle-version N: N: I: mimic source: duplicate-short-description mimic mimic-dkms [debian/control] N: N: The listed binary packages all share the same short description, i.e. the N: first line of the Description field in debian/control. N: N: Please add a word or two, in parentheses if needed, to describe to users N: what they are installing. N: N: It is not okay to rely solely on package naming conventions to indicate N: what is inside. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/description/duplicate N: N: I: mimic: file-references-package-build-path [usr/bin/mimic] N: N: The listed file or maintainer script appears to reference the build path N: used to build the package as specified in the Build-Path field of the N: .buildinfo file. N: N: This is likely to cause the package to be unreproducible, but it may also N: indicate that the package will not work correctly outside of the N: maintainer's own system. N: N: Please note that this tag will not appear unless the .buildinfo file N: contains a Build-Path field. That field is optional. You may have to set N: DEB_BUILD_OPTIONS=buildinfo=+path or use N: --buildinfo-option=--always-include-path with dpkg-buildpackage when N: building. N: N: Please refer to https://reproducible-builds.org/, N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the N: dpkg-genbuildinfo(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: files/contents N: N: I: mimic-dkms: hardening-no-bindnow [usr/lib/mimic/resolve_btfids] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: mimic-dkms: hardening-no-fortify-functions [usr/lib/mimic/extract-btf] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg- buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: mimic-dkms: hardening-no-fortify-functions [usr/lib/mimic/resolve_btfids] N: I: mimic source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.7.0) N: N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the N: timestamp of the latest debian/changelog entry). Please consider updating N: the package to current Policy and setting this control field N: appropriately. N: N: If the package is already compliant with the current standards, you don't N: have to re-upload the package just to adjust the Standards-Version control N: field. However, please remember to update this field next time you upload N: the package. N: N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the N: debian-policy package for a summary of changes in newer versions of N: Policy. N: N: Please refer to N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for N: details. N: N: Visibility: info N: Show-Always: no N: Check: fields/standards-version N: N: I: mimic: systemd-service-file-missing-documentation-key [usr/lib/systemd/system/mimic@.service] N: N: The systemd service file does not contain a Documentation key. N: N: Documentation for systemd service files can be automatically viewed using N: systemctl help servicename if this field is present. N: N: Please refer to the systemd.unit(5) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: systemd N: N: I: mimic-dkms: wrong-section-according-to-package-name net => kernel N: N: This package has a name suggesting that it belongs to a section other than N: the one it is currently categorized in. N: N: Visibility: info N: Show-Always: no N: Check: fields/section N: I: Lintian run was successful. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: N/A Additional... A. autopkgtest: failure The following NEW packages will be installed: dkms kmod libkmod2 linux-doc linux-doc-6.11 lsb-release openssl 0 upgraded, 7 newly installed, 0 to remove and 0 not upgraded. Need to get 40.2 MB of archives. After this operation, 204 MB of additional disk space will be used. Get:1 http://deb.debian.org/debian unstable/main amd64 lsb-release all 12.1-1 [5912 B] Get:2 http://deb.debian.org/debian unstable/main amd64 libkmod2 amd64 33+20240816-2 [63.1 kB] Get:3 http://deb.debian.org/debian unstable/main amd64 kmod amd64 33+20240816-2 [95.6 kB] Get:4 http://deb.debian.org/debian unstable/main amd64 dkms all 3.1.0-1 [53.6 kB] Get:5 http://deb.debian.org/debian unstable/main amd64 linux-doc-6.11 all 6.11.9-1 [38.6 MB] Get:6 http://deb.debian.org/debian unstable/main amd64 linux-doc all 6.11.9-1 [1100 B] Get:7 http://deb.debian.org/debian unstable/main amd64 openssl amd64 3.3.2-2 [1382 kB] Fetched 40.2 MB in 1s (69.1 MB/s) Selecting previously unselected package lsb-release. (Reading database ... 11984 files and directories currently installed.) Preparing to unpack .../lsb-release_12.1-1_all.deb ... Unpacking lsb-release (12.1-1) ... Selecting previously unselected package libkmod2:amd64. Preparing to unpack .../libkmod2_33+20240816-2_amd64.deb ... Unpacking libkmod2:amd64 (33+20240816-2) ... Selecting previously unselected package kmod. Preparing to unpack .../kmod_33+20240816-2_amd64.deb ... Unpacking kmod (33+20240816-2) ... Setting up lsb-release (12.1-1) ... Selecting previously unselected package dkms. (Reading database ... 12025 files and directories currently installed.) Preparing to unpack .../archives/dkms_3.1.0-1_all.deb ... Unpacking dkms (3.1.0-1) ... Selecting previously unselected package linux-doc-6.11. Preparing to unpack .../linux-doc-6.11_6.11.9-1_all.deb ... Unpacking linux-doc-6.11 (6.11.9-1) ... dpkg: error processing archive /var/cache/apt/archives/linux-doc-6.11_6.11.9- 1_all.deb (--unpack): cannot copy extracted data for './usr/share/doc/linux-doc- 6.11/html/_sources/hwmon/w83627ehf.rst.txt' to '/usr/share/doc/linux-doc- 6.11/html/_sources/hwmon/w83627ehf.rst.txt.dpkg-new': failed to write (No space left on device) Selecting previously unselected package linux-doc. Preparing to unpack .../linux-doc_6.11.9-1_all.deb ... Unpacking linux-doc (6.11.9-1) ... Selecting previously unselected package openssl. Preparing to unpack .../openssl_3.3.2-2_amd64.deb ... Unpacking openssl (3.3.2-2) ... Errors were encountered while processing: /var/cache/apt/archives/linux-doc-6.11_6.11.9-1_all.deb E: Sub-process /usr/bin/dpkg returned an error code (1) E: Failed to process build dependencies dkms-autopkgtest FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mimic-dbgsym_0.6.0+ds- 1_amd64.deb deb:mimic-dbgsym arg:/home/philwyett/Development/builder/debian/mimic-dkms-dbgsym_0.6.0+ds- 1_amd64.deb deb:mimic-dkms-dbgsym arg:/home/philwyett/Development/builder/debian/mimic-dkms_0.6.0+ds- 1_amd64.deb deb:mimic-dkms arg:/home/philwyett/Development/builder/debian/mimic_0.6.0+ds-1_amd64.deb deb:mimic /home/philwyett/Development/builder/debian/mimic_0.6.0+ds-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. autopkgtest [01:41:20]: @@@@@@@@@@@@@@@@@@@@ summary dkms-autopkgtest FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mimic-dbgsym_0.6.0+ds- 1_amd64.deb deb:mimic-dbgsym arg:/home/philwyett/Development/builder/debian/mimic-dkms-dbgsym_0.6.0+ds- 1_amd64.deb deb:mimic-dkms-dbgsym arg:/home/philwyett/Development/builder/debian/mimic-dkms_0.6.0+ds- 1_amd64.deb deb:mimic-dkms arg:/home/philwyett/Development/builder/debian/mimic_0.6.0+ds-1_amd64.deb deb:mimic /home/philwyett/Development/builder/debian/mimic_0.6.0+ds-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. E: Autopkgtest run failed. Summary... I believe mimic is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Wiki: https://wiki.kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
