Control: tags -1 +moreinfo

Jorg,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Information, none blocking

Running lintian...
N:
W: sane-utils: no-manual-page [usr/bin/umax_pp]
N: 
N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should
have
N:   a manual page
N:   
N:   Note that though the man program has the capability to check for several
N:   program names in the NAMES section, each of these programs should have
its
N:   own manual page (a symbolic link to the appropriate manual page is
N:   sufficient) because other manual page viewers such as xman or tkman
don't
N:   support this.
N:   
N:   If the name of the manual page differs from the binary by case, man may
be
N:   able to find it anyway; however, it is still best practice to match the
N:   exact capitalization of the executable in the manual page.
N:   
N:   If the manual pages are provided by another package on which this
package
N:   depends, Lintian may not be able to determine that manual pages are
N:   available. In this case, after confirming that all binaries do have
manual
N:   pages after this package and its dependencies are installed, please add
a
N:   Lintian override.
N: 
N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: binary-without-manpage
N: 
N:
I: libsane-common: possible-documentation-but-no-doc-base-registration
N: 
N:   The package ships a .html or .pdf file under /usr/share/doc/. Those
files
N:   are usually documentation, but no files are registered in doc-base.
N:   
N:   Files in folders named examples are exempt from this tag.
N: 
N:   Please refer to Registering Documents using doc-base (Section 9.10) in
the
N:   Debian Policy Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: menus
N: 
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-artec_eplus48u.so.1.2.1]
N: 
N:   Lintian found a spelling error in the given binary. Lintian has a list
of
N:   common misspellings that it looks for. It does not have a dictionary
like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help
of
N:   gettext or a similar tool, please fix the error in the translations as
N:   well as the English text to avoid making the translations fuzzy. With
N:   gettext, for example, this means you should also fix the spelling
mistake
N:   in the corresponding msgids in the *.po files.
N:   
N:   You can often find the word in the source code by running:
N:   
N:    grep -rw <word> <source-tree>
N:   
N:   This tag may produce false positives for words that contain non-ASCII
N:   characters due to limitations in strings.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/spelling
N: 
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-canon_dr.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary afe safe [usr/lib/x86_64-linux-
gnu/sane/libsane-gt68xx.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary begining beginning [usr/lib/x86_64-
linux-gnu/sane/libsane-lexmark_x2600.so.1.2.1]
N:
I: libsane1: spelling-error-in-binary posible possible [usr/lib/x86_64-linux-
gnu/sane/libsane-lexmark_x2600.so.1.2.1]
N:
I: sane-utils: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/saned@.service]
N: 
N:   The systemd service file does not contain a Documentation key.
N:   
N:   Documentation for systemd service files can be automatically viewed
using
N:   systemctl help servicename if this field is present.
N: 
N:   Please refer to the systemd.unit(5) manual page for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: systemd
N: 
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:120]
N: 
N:   Lintian found a spelling error in a manual page. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary
like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help
of
N:   gettext (with the help of po4a, for example) or a similar tool, please
fix
N:   the error in the translations as well as the English text to avoid
making
N:   the translations fuzzy. With gettext, for example, this means you should
N:   also fix the spelling mistake in the corresponding msgids in the *.po
N:   files.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: spelling-error-in-manpage
N: 
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:143]
N:
I: libsane-common: typo-in-manual-page afe safe [usr/share/man/man5/sane-
gt68xx.5.gz:76]
N:
P: sane-backends source: license-problem-gfdl-non-official-text invariant
part is: with no invariant sections, with no front-cover texts, and with no
back-cover [po/fr.po]
N: 
N:   The given source file is licensed under GFDL, but using a non-official
N:   text for the "no invariant sections" part.
N:   
N:   Please ask upstream to always use (case insensitive): with no Invariant
N:   Sections, no Front-Cover Texts, and no Back-Cover Texts.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: cruft
N: 

I: Lintian run was successful.

It would be nice to see the doc base linitan information fixing in a future
upload. Other issue like spelling, it would be great to see them fixed
upstream where applicable.

3. Licenses [4]: Good

If you could file bug report(s) regarding these 'lrc' issue would be good.

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building sane-backends using existing ./sane-
backends_1.3.0.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: local changes detected, the modified files are:
 sane-backends-1.3.0/.version
 sane-backends-1.3.0/backend/pixma/pixma_sane_options.c
 sane-backends-1.3.0/backend/pixma/pixma_sane_options.h
 sane-backends-1.3.0/m4/libtool.m4
 sane-backends-1.3.0/po/bg.po
 sane-backends-1.3.0/po/ca.po
 sane-backends-1.3.0/po/c...@valencia.po
 sane-backends-1.3.0/po/cs.po
 sane-backends-1.3.0/po/da.po
 sane-backends-1.3.0/po/de.po
 sane-backends-1.3.0/po/e...@boldquot.po
 sane-backends-1.3.0/po/e...@quot.po
 sane-backends-1.3.0/po/en_GB.po
 sane-backends-1.3.0/po/eo.po
 sane-backends-1.3.0/po/es.po
 sane-backends-1.3.0/po/fi.po
 sane-backends-1.3.0/po/fr.po
 sane-backends-1.3.0/po/gl.po
 sane-backends-1.3.0/po/he.po
 sane-backends-1.3.0/po/hu.po
 sane-backends-1.3.0/po/it.po
 sane-backends-1.3.0/po/ja.po
 sane-backends-1.3.0/po/ka.po
 sane-backends-1.3.0/po/nb.po
 sane-backends-1.3.0/po/nl.po
 sane-backends-1.3.0/po/pl.po
 sane-backends-1.3.0/po/pt.po
 sane-backends-1.3.0/po/ru.po
 sane-backends-1.3.0/po/sane-backends.pot
 sane-backends-1.3.0/po/stamp-po
 sane-backends-1.3.0/po/sv.po
 sane-backends-1.3.0/po/uk.po
 sane-backends-1.3.0/po/zh_CN.po
dpkg-source: info: Hint: make sure the version in debian/changelog matches
the unpacked source tree
dpkg-source: info: you can integrate the local changes with dpkg-source --
commit
dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/sane-backends_1.3.0-2.diff.BG5gqK
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

Jorg, Package is in good shape. The main issue is the failure of test 5.

I believe sane-backends is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Wiki: https://wiki.kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to