Control: tags -1 +moreinfo Shreyaa,
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: phylorna: empty-binary-package
N:
N: This binary package appears to be empty, and its description does not
say
N: that it's a metapackage or a transitional package. This is often due to
N: problems with updating debhelper *.install files during package renames
or
N: similar problems where installation rules don't put files in the correct
N: place.
N:
N: If the package is deliberately empty, please mention in the package long
N: description one of the phrases "metapackage", "dummy", "dependency
N: package", or "empty package".
N:
N: Previously, Lintian also accepted the use of "virtual package". This was
N: removed to avoid overloading the term. If you have been relying on the
N: phrase "virtual package" to avoid this warning, please replace it with
one
N: of the others.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/empty-package
N:
N:
W: phylorna source: no-nmu-in-changelog [debian/changelog:1]
N:
N: When you NMU a package, that fact should be mentioned on the first line
in
N: the changelog entry. Use the words "NMU" or "Non-maintainer upload"
(case
N: insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is byte-for-
byte
N: identical to the maintainer or one of the uploaders. If this is a local
N: package (not intended for Debian), you can suppress this warning by
N: putting "local" in the version number or "local package" on the first
line
N: of the changelog entry.
N:
N: Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
N: Developer's Reference for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: nmu
N: Renamed from: changelog-should-mention-nmu
N:
N:
W: phylorna source: source-contains-debian-substvars [debian/phylorna-
v1.0.0.substvars]
N:
N: Lintian found a substvars file in the Debian diff for this source
package.
N: The debian/substvars (or debian/package.substvars) file is usually
N: generated and modified dynamically by debian/rules targets, in which
case
N: it must be removed by the clean target.
N:
N: Please refer to Variable substitutions: debian/substvars (Section 4.10)
in
N: the Debian Policy Manual for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/substvars
N: Renamed from: diff-contains-substvars
N:
N:
W: phylorna source: source-nmu-has-incorrect-version-number 1.0.0-2
[debian/changelog:1]
N:
N: A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
N: native package). This is to prevent stealing version numbers from the
N: maintainer.
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is byte-for-
byte
N: identical to the maintainer or one of the uploaders. If this is a local
N: package (not intended for Debian), you can suppress this warning by
N: putting "local" in the version number or "local package" on the first
line
N: of the changelog entry.
N:
N: Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
N: Developer's Reference for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: nmu
N:
N:
I: phylorna: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Please refer to General guidelines for package descriptions (Section
N: 6.2.1) in the Debian Developer's Reference and The long description
N: (Section 6.2.3) in the Debian Developer's Reference for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
N:
N:
P: phylorna source: maintainer-manual-page [debian/phylorna-
v1.0.0/usr/share/doc-base/phylorna-v1.0.0.phylorna-v1.0.0]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the
manual
N: page upstream and ask them to include in their version control system,
and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy
Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
N:
N:
P: phylorna source: trailing-whitespace [debian/changelog:3]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also
cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: phylorna source: trailing-whitespace [debian/control:21]
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/phylorna-1.0.0$ uscan --
force-download
uscan warn: unrecognized option pgmode=auto
uscan warn: In debian/watch no matching files for watch line
https://github.com/bioDS/phyloRNA/releases .*/v?(\d\S+)\.tar\.gz
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Not performed it this time.
7. Install [No previous installs]: Not performed it this time.
8. Upgrade [Over previous installs if any]: Not performed it this time.
Additional...
A. The changelog entry for a new version or package needs to be '-1'.
B. Remove trailing white space from changelog.
Summary...
I believe phylorna is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
Donations...
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Liberapay: https://liberapay.com/kathenas
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Wiki: https://wiki.kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
