Hi Philip,

thanks for your review.
 
Is it enough to license the debian/patches directory under GPL2+?

CU
Jörg

Am Donnerstag, dem 14.11.2024 um 12:30 +0000 schrieb Phil Wyett:
> Jorg,
> 
> Oops, getting carried away again.
> 
> In 'debian/copyright' the 'Files: debian/*' section should have same license
> as 'Files: *' section.
> 
> Regards
> 
> Phil
> 
> On Thu, 2024-11-14 at 12:25 +0000, Phil Wyett wrote:
> > Control: tags -1 +confirmed
> > 
> > Jorg,
> > 
> > Preamble...
> > 
> > Thank you for taking the time to prepare this package and your contribution
> > to the Debian project.
> > 
> > The review below is for assistance. This review is offered to help package
> > submitters to Debian mentors inorder to improve their packages prior to
> > possible sponsorship into Debian. There is no obligation on behalf of the
> > submitter to make any alterations based upon information provided in the
> > review.
> > 
> > Review...
> > 
> > 1. Build:
> > 
> >   * pbuilder [1]: Good
> >   * sbuild [2]: Good
> > 
> > 2. Lintian [3]: Good
> > 
> > 3. Licenses [4]: Good
> > 
> > 4. Watch file [uscan --force-download]: Good
> > 
> > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
> > 
> > 6. Reproducible builds [5]: Good
> > 
> > 7. Install [No previous installs]: Good
> > 
> > 8. Upgrade [Over previous installs if any]: Good
> > 
> > Summary...
> > 
> > Jorg, Package is in great shape, just one thing. The 'debian/*' section in
> > 'debian/copyright' should be the same license as the main code of the
> > package
> > i.e. 'debian/*'. Can you please make this change and upload before any DD
> > upload.
> > 
> > I believe mwc is ready for review/possible sponsorship. Could a Debian
> > Developer (DD) with available free time, please review this package and
> > upload if you feel it is ready.
> > 
> > Regards
> > 
> > Phil
> > 
> > [1] pbuilder:
> > 
> >   * Command: sudo pbuilder build <PACKAGE>.dsc
> >   * Document: https://wiki.ubuntu.com/PbuilderHowto.
> >   * Document: https://wiki.debian.org/PbuilderTricks
> > 
> > [2] sbuild:
> > 
> >   * Command: sbuild <PACKAGE>.dsc
> >   * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
> >   * Document: https://wiki.debian.org/sbuild
> > 
> > [3] lintian:
> > 
> >   * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> > *.changes, *.buildinfo). Each can throw up different results, so be
> > thorough.
> >   * Document: https://wiki.debian.org/Lintian
> > 
> > [4] lrc:
> > 
> >   * Command: lrc
> >   * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
> > 
> > [5] reprotest
> > 
> >   * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --
> > auto-
> > build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
> >   * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
> >   * Document: https://wiki.debian.org/ReproducibleBuilds/
> >   * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
> > 
> 

-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key        : 8CA1D25D
CAcert Key S/N : 0E:D4:56


Jörg Frings-Fürst
D-54470 Lieser


git:      https://git.jff.email/cgit/

Skype:    jff-skype@jff.email
Jami:     joergfringsfuerst
Telegram: @joergfringsfuerst
Matrix:   @joergff:matrix.snct-gmbh.de

My wish list: 
 - Please send me a picture from the nature at your home.




Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to