Colin, Fresh review based on upload - 2024-11-12 16:41
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Good 3. Licenses [4]: Issue, maybe some false positives philwyett@ks-tarkin:~/Development/builder/debian/qatengine-1.6.1$ lrc en: Versions: recon 3.0 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck MIT | Expat atomic-ops.h BSD-3-Clause | OpenSSL e_qat_err.c BSD-3-Clause | OpenSSL e_qat_err.h BSD-3-Clause | OpenSSL e_qat.txt BSD-3-Clause | OpenSSL LICENSE.BORINGSSL BSD-3-Clause | OpenSSL LICENSE.OPENSSL BSD-3-Clause | Apache-2.0 LICENSE.OPENSSL3.0 BSD-3-Clause | Expat LICENSE.PLOCK MIT | Expat plock.c MIT | Expat plock.h BSD-3-Clause | OpenSSL qat_bssl_err.c BSD-3-Clause | OpenSSL qat_bssl_err.h BSD-3-Clause | BSD-3-clause and/or OpenSSL qat_constant_time.h BSD-3-Clause | GPL-2 qat_contig_mem/LICENSE.GPL BSD-3-Clause | GPL-2 qat_contig_mem/qat_contig_mem.c BSD-3-Clause | GPL-2 qat_contig_mem/qat_contig_mem.h BSD-3-Clause | GPL-2 qat_contig_mem/qat_contig_mem_test.c MIT | BSD-3-clause and/or Expat qatengine.spec BSD-3-Clause | BSD-3-clause and/or OpenSSL qat_hw_ciphers.c GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/200xx/multi_process/200xx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/200xx/multi_thread/200xx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/4xxx/multi_process/4xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/4xxx/multi_thread/4xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c3xxx/multi_process/c3xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c3xxx/multi_thread/c3xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c4xxx/multi_process/c4xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c4xxx/multi_thread/c4xxx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c6xx/multi_process/c6xx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/c6xx/multi_thread/c6xx_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/dh895xcc/multi_process/dh895xcc_dev0.conf GPL-2 | BSD-3-clause and/or GPL-2 qat_hw_config/dh895xcc/multi_thread/dh895xcc_dev0.conf 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... Colin, This latest upload fixes all issues - kudos, but the license/'debian/copyright' issues remain. These need to be resolved prior to sponsorship. I believe qatengine is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
