Hi Jörg, Thanks for preparing the new cil revision, and notably for closing #1041501! Also, Thanks Phil for taking the time to do a pre-review! :)
To complement on some of the information provided by Phil Wyett: > A. autopkgtest failure > > autopkgtest [19:06:15]: test autodep8-perl-recommends: /usr/share/pkg-perl- > autopkgtest/runner runtime-deps-and-recommends > autopkgtest [19:06:15]: test autodep8-perl-recommends: > [----------------------- [… trimmed noisy TAP output …] > # Can't locate Git.pm in @INC (you may need to install the Git module) > (@INC > entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 > /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 > /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux- > gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl) at > /usr/share/perl5/CIL/Git.pm line 28. > # BEGIN failed--compilation aborted at /usr/share/perl5/CIL/Git.pm line > 28. > not ok 23 - /usr/bin/perl -wc /usr/share/perl5/CIL/Git.pm exited > successfully [… trimmed further similar tests not passing …] > E: Autopkgtest run failed. The package does not declare a Testsuite, and does not provide a debian/tests/control file, so naively, it should not have a test suite kicking in. But, cil is a "Section: perl" package, and autopkgtest has been capable of automatically deriving a test control file to trigger upstream's test suite. This test control file is built on top of autodep8-perl, documented on Debian Perl Team's autopkgtest[1] page, and is what triggered the test run by Phil. The package may be uploaded as-is, as the official debci will not trigger while the Testsuite is not declared, and there are no debian/tests/control file. However, I believe introduction of the "Testsuite: autopkgtest-pkg-perl" would be beneficial to cil package. There will be a few adjustments needed to the test environment to resolve test items failing when missing git; that can be resolved by introducing a dependency on git, or by skipping the affected test items. See [1] for options to alter the autopkgtest-pkg-perl environment. [1]: https://perl-team.pages.debian.net/autopkgtest.html As a side note, it may be relevant to team maintain cil under the Debian Perl Team umbrella. You would of course be welcome to join. :) > B. Wishlist > > Add 'debian/upstream/metadata' in a future upload. As far as I could tell, the historical upstream archived the project, so the Debian package became de facto upstream, so filing an appropriate d/u/metadata may prove to be a problem for a number of fields (at least Bug fields), until a newer upstream appears. That being said, several other fields may be filed, at least Repository. See DEP12[2] and the wiki[3] for details on the specification. It is not necessary to file each and every fields, but it is interesting to file fields that seem relevant. [2]: https://dep-team.pages.debian.net/deps/dep12/ [3]: https://wiki.debian.org/UpstreamMetadata Have a nice day, :) -- .''`. Étienne Mollier <emoll...@debian.org> : :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/pts/2, please excuse my verbosity `-
signature.asc
Description: PGP signature
