Control: tags -1 +moreinfo Richard,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Issue piuparts: 0m16.7s DUMP: (Reading database ... 11781 files and directories currently installed.) Purging configuration files for keyd (2.5.0-1) ... /var/lib/dpkg/info/keyd.postrm: 19: groupdel: not found dpkg: error processing package keyd (--purge): installed keyd package post-removal script subprocess returned error exit status 127 dpkg: warning: ignoring request to remove keyd-application-mapper which isn't installed dpkg: warning: ignoring request to remove keyd-dbgsym which isn't installed Errors were encountered while processing: keyd 0m16.7s ERROR: Command failed (status=1): ['schroot', '--preserve- environment', '--run-session', '--chroot', 'session:unstable-amd64-sbuild- b53d308a-7073-11ef-9013-525400cf9b02-piuparts', '--directory', '/', '-u', 'root', '--', 'dpkg', '--purge', 'keyd', 'keyd-application-mapper', 'keyd- dbgsym'] (Reading database ... 11781 files and directories currently installed.) Purging configuration files for keyd (2.5.0-1) ... /var/lib/dpkg/info/keyd.postrm: 19: groupdel: not found dpkg: error processing package keyd (--purge): installed keyd package post-removal script subprocess returned error exit status 127 dpkg: warning: ignoring request to remove keyd-application-mapper which isn't installed dpkg: warning: ignoring request to remove keyd-dbgsym which isn't installed Errors were encountered while processing: keyd 0m16.9s DEBUG: Terminate schroot session '/var/run/schroot/mount/unstable- amd64-sbuild-b53d308a-7073-11ef-9013-525400cf9b02-piuparts' 0m16.9s DEBUG: Starting command: ['schroot', '--end-session', '--chroot', 'session:unstable-amd64-sbuild-b53d308a-7073-11ef-9013-525400cf9b02- piuparts'] 0m17.1s DEBUG: Command ok: ['schroot', '--end-session', '--chroot', 'session:unstable-amd64-sbuild-b53d308a-7073-11ef-9013-525400cf9b02- piuparts'] 0m17.1s ERROR: piuparts run ends. E: Piuparts run failed. 2. Lintian [3]: Issue I: keyd-application-mapper: capitalization-error-in-description Gnome GNOME N: N: Lintian found a possible capitalization error in the package description. N: Lintian has a list of common capitalization errors, primarily of upstream N: projects, that it looks for. It does not have a dictionary like a spelling N: checker does. N: N: This is a particularly picky check of capitalization in package N: descriptions, since they're very visible to end users, but it will have N: false positives for project names used in a context where they should be N: lowercase, such as package names or executable names. N: N: Visibility: info N: Show-Always: no N: Check: fields/description N: N: I: keyd: hardening-no-bindnow [usr/bin/keyd] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: keyd: systemd-service-file-missing-documentation-key [usr/lib/systemd/system/keyd.service] N: N: The systemd service file does not contain a Documentation key. N: N: Documentation for systemd service files can be automatically viewed using N: systemctl help servicename if this field is present. N: N: Please refer to the systemd.unit(5) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: systemd 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: N/A Summary... I believe keyd is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part