Control: tags -1 +moreinfo Takashi,
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
W: libhinoko-dev: gir-package-name-does-not-match gir1.2-hinoko-1.0-dev
[usr/share/gir-1.0/Hinoko-1.0.gir]
N:
N: Development packages that contain public GObject-Introspection XML files
N: (/usr/share/gir-1.0/Foo-23.gir or
N: /usr/lib/${DEB_HOST_MULTIARCH}/gir-1.0/Foo-23.gir) should be named
N: gir1.2-foo-23-dev if the GIR XML is the only content of the package, or
N: should have a versioned Provides for gir1.2-foo-23-dev (=
N: ${binary:Version}) if the package contains other development files.
N:
N: Since gobject-introspection 1.78.1-6 (Debian trixie), the recommended
way
N: to populate the Provides fields is to use debhelper and dh_girepository,
N: via the gir addon or the dh-sequence-gir virtual package, and add
N: Provides: ${gir:Provides} to packages that contain public GIR XML.
N:
N: For example, libgtk-3-dev contains Gtk-3.0.gir, Gdk-3.0.gir and
N: GdkX11-3.0.gir, so it should have Provides: gir1.2-gtk-3.0-dev,
Provides:
N: gir1.2-gdk-3.0-dev and Provides: gir1.2-gdkx11-3.0-dev.
N:
N: Please refer to usr/share/doc/gobject-introspection/policy.txt for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: desktop/gnome/gir
W: libhinoko-dev: stray-devhelp-documentation
[usr/share/doc/hinoko/hinoko.devhelp2]
N:
N: The named file is not in the Devhelp search path
(/usr/share/devhelp/books
N: or /usr/share/gtk-doc/html) and also not located in a directory that is
N: accessible via a symbolic link from that search path. Devhelp cannot
find
N: that file.
N:
N: For Devhelp documentation installed outside the search path (such as
N: /usr/share/doc), create a symbolic link in /usr/share/gtk-doc/html that
N: points to the documentation directory.
N:
N: Please refer to https://apps.gnome.org/app/org.gnome.Devhelp/ for
details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/devhelp
N: Renamed from: package-contains-devhelp-file-without-symlink
N:
N: Screen: examples/ship/devhelp
N: Advocates: "Lintian Maintainers" <lintian-ma...@debian.org>
N: Reason:
N: Any Devhelp files shipped in the examples are not expected to
be discoverable by
N: the Devhelp browsing tool.
I: libhinoko source: out-of-date-standards-version 4.6.2 (released 2022-12-
17) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider
updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you
don't
N: have to re-upload the package just to adjust the Standards-Version
control
N: field. However, please remember to update this field next time you
upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
I: libhinoko-dev: possible-documentation-but-no-doc-base-registration
N:
N: The package ships a .html or .pdf file under /usr/share/doc/. Those
files
N: are usually documentation, but no files are registered in doc-base.
N:
N: Files in folders named examples are exempt from this tag.
N:
N: Please refer to Registering Documents using doc-base (Section 9.10) in
the
N: Debian Policy Manual for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: menus
I: libhinoko1: symbols-file-missing-build-depends-package-field
libhinoko.so.1 [symbols]
N:
N: The symbols file for this package does not contain a Build-Depends-
Package
N: meta-information field.
N:
N: This field specifies the name of the -dev package associated to the
N: library and is used by dpkg-shlibdeps(1) to make sure that the
dependency
N: generated is at least as strict as the corresponding build dependency.
N:
N: This is useful as allows packages to not hardcode this information
N: multiple times.
N:
N: Note that the format of deb-symbols(5) files requires that the *
N: Build-Depends-Package: line should start in column one of the file and
not
N: be indented to align with the symbols themselves. Please do not use the
N: placeholder #PACKAGE#. The development package for your shared library
N: must be stated explicitly.
N:
N: Please refer to The symbols File Format (Section 8.6.3.2) in the Debian
N: Policy Manual, the deb-symbols(5) manual page, the dpkg-shlibdeps(1)
N: manual page,
N:
https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#librarysymbols
,
N: and Bug#944047 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/shlibs
N:
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not tested at present
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe libhinoko is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' tag on the
Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
