Control: tags -1 +moreinfo Mateusz,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue I: audacious-plugins source: patch-not-forwarded-upstream [debian/patches/0001-Do-not-hard-code-build-architecture-pkg-config.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch I: audacious-plugins: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/audacious/General/song_change.so] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg- buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: audacious-plugins: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/audacious/Input/console.so] N: I: audacious-plugins: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/audacious/Output/alsa.so] N: I: audacious-plugins: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/audacious/Output/oss4.so] N: I: audacious-plugins: hardening-no-fortify-functions [usr/lib/x86_64-linux- gnu/audacious/Output/sndio-ng.so] 3. Licenses [4]: Issue, chance of false positives philwyett@ks-tarkin:~/Development/builder/debian/mentoring/audacious-plugins- 4.4$ lrc : Versions: recon 1.16 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck BSD-2-clause | FSFAP INSTALL BSD-2-clause | Expat src/aosd/ghosd-license GPL-3 | GPL src/cdaudio/cdaudio-ng.cc BSD-2-clause | LGPL src/console/gme_notes.txt BSD-2-clause | LGPL src/console/gme_readme.txt BSD-2-clause | GPL-2 src/psf/peops/License.txt BSD-2-clause | GPL-2 src/psf/peops2/License.txt GPL-3 | GPL src/skins-qt/actions-mainwin.h GPL-3 | GPL src/skins-qt/actions-playlist.h GPL-3 | GPL src/skins-qt/actions.cc GPL-3 | GPL src/skins-qt/button.cc GPL-3 | GPL src/skins-qt/button.h GPL-3 | GPL src/skins-qt/dnd.h GPL-3 | GPL src/skins-qt/eq-graph.cc GPL-3 | GPL src/skins-qt/eq-graph.h GPL-3 | GPL src/skins-qt/eq-slider.cc GPL-3 | GPL src/skins-qt/eq-slider.h GPL-3 | GPL src/skins-qt/equalizer.cc GPL-3 | GPL src/skins-qt/equalizer.h GPL-3 | GPL src/skins-qt/hslider.cc GPL-3 | GPL src/skins-qt/hslider.h GPL-3 | GPL src/skins-qt/main.cc GPL-3 | GPL src/skins-qt/main.h GPL-3 | GPL src/skins-qt/menurow.cc GPL-3 | GPL src/skins-qt/menurow.h GPL-3 | GPL src/skins-qt/monostereo.cc GPL-3 | GPL src/skins-qt/monostereo.h GPL-3 | GPL src/skins-qt/number.cc GPL-3 | GPL src/skins-qt/number.h GPL-3 | GPL src/skins-qt/playlist-slider.cc GPL-3 | GPL src/skins-qt/playlist-slider.h GPL-3 | GPL src/skins-qt/playlist-widget.cc GPL-3 | GPL src/skins-qt/playlist-widget.h GPL-3 | GPL src/skins-qt/playlistwin.cc GPL-3 | GPL src/skins-qt/playlistwin.h GPL-3 | GPL src/skins-qt/playstatus.cc GPL-3 | GPL src/skins-qt/playstatus.h GPL-3 | GPL src/skins-qt/plugin.cc GPL-3 | GPL src/skins-qt/plugin.h GPL-3 | GPL src/skins-qt/search-select.cc GPL-3 | GPL src/skins-qt/skin-ini.cc GPL-3 | GPL src/skins-qt/skin.cc GPL-3 | GPL src/skins-qt/skin.h GPL-3 | GPL src/skins-qt/skins_cfg.cc GPL-3 | GPL src/skins-qt/skins_cfg.h GPL-3 | GPL src/skins-qt/skins_util.cc GPL-3 | GPL src/skins-qt/skins_util.h GPL-3 | GPL-2 src/skins-qt/skinselector.cc GPL-3 | GPL src/skins-qt/skinselector.h GPL-3 | GPL src/skins-qt/svis.cc GPL-3 | GPL src/skins-qt/textbox.cc GPL-3 | GPL src/skins-qt/textbox.h GPL-3 | GPL src/skins-qt/vis-callbacks.cc GPL-3 | GPL src/skins-qt/vis-callbacks.h GPL-3 | GPL src/skins-qt/vis.cc GPL-3 | GPL src/skins-qt/vis.h GPL-3 | GPL src/skins/actions-mainwin.h GPL-3 | GPL src/skins/actions-playlist.h GPL-3 | GPL src/skins/actions.cc GPL-3 | GPL src/skins/button.cc GPL-3 | GPL src/skins/button.h GPL-3 | GPL src/skins/dnd.h GPL-3 | GPL src/skins/eq-graph.cc GPL-3 | GPL src/skins/eq-graph.h GPL-3 | GPL src/skins/eq-slider.cc GPL-3 | GPL src/skins/eq-slider.h GPL-3 | GPL src/skins/equalizer.cc GPL-3 | GPL src/skins/equalizer.h GPL-3 | GPL src/skins/hslider.cc GPL-3 | GPL src/skins/hslider.h GPL-3 | GPL src/skins/main.cc GPL-3 | GPL src/skins/main.h GPL-3 | GPL src/skins/menurow.cc GPL-3 | GPL src/skins/menurow.h GPL-3 | GPL src/skins/monostereo.cc GPL-3 | GPL src/skins/monostereo.h GPL-3 | GPL src/skins/number.cc GPL-3 | GPL src/skins/number.h GPL-3 | GPL src/skins/playlist-slider.cc GPL-3 | GPL src/skins/playlist-slider.h GPL-3 | GPL src/skins/playlist-widget.cc GPL-3 | GPL src/skins/playlist-widget.h GPL-3 | GPL src/skins/playlistwin.cc GPL-3 | GPL src/skins/playlistwin.h GPL-3 | GPL src/skins/playstatus.cc GPL-3 | GPL src/skins/playstatus.h GPL-3 | GPL src/skins/plugin.cc GPL-3 | GPL src/skins/plugin.h GPL-3 | GPL src/skins/search-select.cc GPL-3 | GPL src/skins/skin-ini.cc GPL-3 | GPL src/skins/skin.cc GPL-3 | GPL src/skins/skin.h GPL-3 | GPL src/skins/skins_cfg.cc GPL-3 | GPL src/skins/skins_cfg.h GPL-3 | GPL src/skins/skins_util.cc GPL-3 | GPL src/skins/skins_util.h GPL-3 | GPL-2 src/skins/skinselector.cc GPL-3 | GPL src/skins/skinselector.h GPL-3 | GPL src/skins/svis.cc GPL-3 | GPL src/skins/textbox.cc GPL-3 | GPL src/skins/textbox.h GPL-3 | GPL src/skins/vis-callbacks.cc GPL-3 | GPL src/skins/vis-callbacks.h GPL-3 | GPL src/skins/vis.cc GPL-3 | GPL src/skins/vis.h GPL-3 | GPL src/songchange/formatter.cc GPL-3 | GPL src/songchange/songchange_crossplatform.h 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Not performed 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe audacious-plugins is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
