Control: tags -1 +moreinfo Mateusz,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue I: gxkb source: repackaged-source-not-advertised [debian/copyright] N: N: The debian/copyright file mentions Files-Excluded but the source version N: has no repack suffix. N: N: Repackaged sources are expected to indicate in their version number that N: they are different from the upstream release. It is commonly done by N: adding a repack suffix to the upstream version. N: N: The choice of repack suffix depends on the reason for repackaging. When N: some files were excluded because licensing was a concern, the suffix +dfsg N: may be appropriate. In more generic cases, one could chose +ds. N: N: Upstream sources are sometimes repackaged by accident when using old N: versions of dh_make. It can also happen when a maintainer invokes the N: dh_make option --createorig even though it is not needed. N: N: According to the Debian Developer's Reference 6.7.8.2, the repack suffix N: is not required. N: N: Please include such a suffix in the changelog version number to avoid this N: warning. N: N: Please refer to Bug#471537 and N: https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html N: for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 Needs to be '+ds' repacked. P: gxkb source: maintainer-desktop-entry [debian/gxkb.desktop] N: N: The maintainer keeps a desktop entry in ./debian. Please forward the N: desktop entry upstream and ask them to include it in their version control N: system, and in their next release. N: N: If the desktop entry was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/desktop-entries 3. Licenses [4]: Issue philwyett@ks-tarkin:~/Development/builder/debian/mentoring/gxkb-0.9.6$ lrc : Versions: recon 1.16 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-2+ | FSFAP doc/INSTALL 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe gxkb is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
