Hi,
Am Tue, Aug 20, 2024 at 06:08:54PM +0200 schrieb наб:
> On Tue, Aug 20, 2024 at 10:44:24AM +0200, Andreas Tille wrote:
> > At first I need to say that my personal sponsoring style is that I
> > sponsor only from Git repositories on Salsa (for various reasons).
> https://salsa.debian.org/nabijaczleweli/archivemount
> it even passes the standard Salsa pipelines
> (except for reprotest:
> https://salsa.debian.org/nabijaczleweli/archivemount/-/jobs/6154192#L578)
That looks great.
> but it looks like that's because the reprotest driver is broken)
I admit I would tolerate failure in reprotest for sponsoring.
Unfortunately it does not build in my local pbuilder:
dh_auto_build
make -j8 "INSTALL=install --strip-program=true"
make[1]: Entering directory '/build/archivemount-1'
g++ -g -O2 -ffile-prefix-map=/build/archivemount-1=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
-I/usr/include/fuse3 -O3 -g -Wall -Wextra -fno-exceptions -fno-rtti
-Wno-missing-field-initializers -std=c++2b -Wdate-time -D_FORTIFY_SOURCE=2
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DVERSION='"1-1"' -DNDEBUG -Wl,-z,relro
-Wl,-z,now archivemount.cpp -larchive -lfuse3 -lpthread -o archivemount
awk '{ gsub(/ \^/, " \\(ha"); gsub(/ ~/, " \\(ti"); if($1 == ".Dd") $2 =
"August 20, 2024"; if($1 == ".Dt") print ".ds doc-volume-operating-system";
if($1 == ".Os") $2 = "archivemount-ng 1-1"; print}' < archivemount.1.in >
archivemount.1
/usr/bin/ld: /lib/x86_64-linux-gnu/liblz4.so.1: undefined reference to
`LZ4_XXH32'
/usr/bin/ld: /lib/x86_64-linux-gnu/liblz4.so.1: undefined reference to
`LZ4_XXH32_digest'
/usr/bin/ld: /lib/x86_64-linux-gnu/liblz4.so.1: undefined reference to
`LZ4_XXH32_update'
/usr/bin/ld: /lib/x86_64-linux-gnu/liblz4.so.1: undefined reference to
`LZ4_XXH32_reset'
collect2: error: ld returned 1 exit status
make[1]: *** [<builtin>: archivemount] Error 1
If I use the following patch:
$ git diff
diff --git a/debian/control b/debian/control
index b67d02d..45a6ec1 100644
--- a/debian/control
+++ b/debian/control
@@ -13,6 +13,7 @@ Build-Depends: debhelper,
libfuse3-dev,
libarchive-dev,
pkgconf,
+ liblz4-dev
Package: archivemount
Architecture: any
the build works fine. No idea why Salsa CI installs liblz4-dev but
pbuilder does obviously not.
> > However, there where
> > *a lot* of package modernisations (which I applaude) that need to be
> > mentioned in d/changelog.
> tbh I considered the old packaging unsalvageable;
> except for a merged changelog, this is an entirely new debian/
> (copied from urlview; it's really quite a similar situation to urlview),
> so I don't really know what the changes... are? because I didn't make any
ACK, I fully understand what you mean. However, if you take over some
existing package you should list the changes you did. For doing so I'd
recommend routine-update (inside the package with the same name). It
modernises some existing package including calling Janitor tools and
maintains the changelog accordingly.
> > Starting with Vcs-fields, Standards-Version,
> > recent debhelper compat level, etc.
> Added all of those to d/changelog (by diff against 4b94b04^).
Fine.
> If any particular cetera (or category of cetera) cross your mind,
> I can find what their previous values were and list them as well.
I do not want to by over-picky. But debhelper compat level and
Standards-Version are mandatory for mentioning.
> I've uploaded this updated package to mentors.d.o.
I do not require you to upload to mentors. If you consider adapting
the Build-Depends I simply sponsor from Git.
Thanks a lot for your work
Andreas.
--
https://fam-tille.de
