Control: tags -1 +confirmed

Andrea,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Informational, non blocking

I: markdown source: quilt-patch-missing-description
[debian/patches/debian.patch]
N: 
N:   quilt patch files should start with a description of patch. All lines
N:   before the start of the patch itself are considered part of the
N:   description. You can edit the description with quilt header -e when the
N:   patch is at the top of the stack.
N:   
N:   As well as a description of the purpose and function of the patch, the
N:   description should ideally contain author information, a URL for the bug
N:   report (if any), Debian or upstream bugs fixed by it, upstream status,
the
N:   Debian version and date the patch was first included, and any other
N:   information that would be useful if someone were investigating the patch
N:   and underlying problem. Please consider using the DEP 3 format for this
N:   information.
N: 
N:   Please refer to https://dep-team.pages.debian.net/deps/dep3/ for
details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/quilt

I: markdown source: upstream-metadata-missing-repository
[debian/upstream/metadata]
N: 
N:   The DEP 12 metadata file does not specify the location of upstream's
N:   version control repository (ie. the Repository and Repository-Browse
N:   fields are missing).
N:   
N:   The upstream metadata can be found in the source package in the file
N:   debian/upstream/metadata.
N: 
N:   Please refer to https://dep-team.pages.debian.net/deps/dep12/ for
details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/upstream/metadata

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe markdown is ready for sponsorship/upload. Could a Debian Developer
(DD) with available free time, please review this package and upload if you
feel it is ready.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to