Control: tags -1 +moreinfo

Lorenzo,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Issue

0m9.8s DUMP: 
  Reading package lists...
  Building dependency tree...
  Reading state information...
  Some packages could not be installed. This may mean that you have
  requested an impossible situation or if you are using the unstable
  distribution that some required packages have not yet been created
  or been moved out of Incoming.
  The following information may help to resolve the situation:
  
  The following packages have unmet dependencies:
   runit-run : Conflicts: runit-init but 2.1.2-60 is to be installed
  E: Unable to correct problems, you have held broken packages.
0m9.8s ERROR: Command failed (status=100): ['schroot', '--preserve-
environment', '--run-session', '--chroot', 'session:unstable-amd64-sbuild-
08485034-5532-11ef-9085-5254001e7516-piuparts', '--directory', '/', '-u',
'root', '--', 'apt-get', '-y', '--allow-downgrades', 'install', './tmp/getty-
run_2.1.2-60_all.deb', './tmp/runit-dbgsym_2.1.2-60_amd64.deb', './tmp/runit-
init_2.1.2-60_amd64.deb', './tmp/runit-run_2.1.2-60_all.deb',
'./tmp/runit_2.1.2-60_amd64.deb']
  Reading package lists...
  Building dependency tree...
  Reading state information...
  Some packages could not be installed. This may mean that you have
  requested an impossible situation or if you are using the unstable
  distribution that some required packages have not yet been created
  or been moved out of Incoming.
  The following information may help to resolve the situation:
  
  The following packages have unmet dependencies:
   runit-run : Conflicts: runit-init but 2.1.2-60 is to be installed
  E: Unable to correct problems, you have held broken packages.
  
0m10.1s DEBUG: Terminate schroot session '/var/run/schroot/mount/unstable-
amd64-sbuild-08485034-5532-11ef-9085-5254001e7516-piuparts'
0m10.1s DEBUG: Starting command: ['schroot', '--end-session', '--chroot',
'session:unstable-amd64-sbuild-08485034-5532-11ef-9085-5254001e7516-
piuparts']
0m10.3s DEBUG: Command ok: ['schroot', '--end-session', '--chroot',
'session:unstable-amd64-sbuild-08485034-5532-11ef-9085-5254001e7516-
piuparts']
0m10.3s ERROR: piuparts run ends.

E: Piuparts run failed.

2. Lintian [3]: Issue

I: runit-init: conflicts-with-version bfh-container (<< 20211009-24~)
N: 
N:   An earlier-than version clause is normally an indication that Breaks
N:   should be used instead of Conflicts. Breaks is a weaker requirement that
N:   provides the package manager more leeway to find a valid upgrade path.
N:   Conflicts should only be used if two packages can never be unpacked at
the
N:   same time, or for some situations involving virtual packages (where a
N:   version clause is not appropriate). In particular, when moving files
N:   between packages, use Breaks plus Replaces, not Conflicts plus Replaces.
N: 
N:   Please refer to Conflicting binary packages - Conflicts (Section 7.4) in
N:   the Debian Policy Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/package-relations

I: runit-init: conflicts-with-version molly-guard (<< 0.8.3~)

I: runit-init: conflicts-with-version progress-linux-container (<< 20221002-
12~)

I: runit: hardening-no-fortify-functions [usr/bin/chpst]
N: 
N:   This package provides an ELF binary that lacks the use of fortified libc
N:   functions. Either there are no potentially unfortified functions called
by
N:   any routines, all unfortified calls have already been fully validated at
N:   compile-time, or the package was not built with the default Debian
N:   compiler flags defined by dpkg-buildflags. If built using dpkg-
buildflags
N:   directly, be sure to import CPPFLAGS.
N:   
N:   NB: Due to false-positives, Lintian ignores some unprotected functions
N:   (e.g. memcpy).
N: 
N:   Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/hardening
N:
I: runit: hardening-no-fortify-functions [usr/bin/runsv]
N:
I: runit: hardening-no-fortify-functions [usr/bin/runsvdir]
N:
I: runit: hardening-no-fortify-functions [usr/bin/sv]
N:
I: runit: hardening-no-fortify-functions [usr/bin/svlogd]
N:
I: runit: hardening-no-fortify-functions [usr/sbin/runit]
N:
I: runit: hardening-no-fortify-functions [usr/sbin/utmpset]

I: runit source: patch-not-forwarded-upstream [debian/patches/0028-Disable-
sv-test]
N: 
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:   
N:   Please forward the patch and try to have it included in upstream's
version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes
to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch
N:
I: runit source: patch-not-forwarded-upstream [debian/patches/0029-fix-ftbfs-
with-gcc14.patch]

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: Not performed at this time

Summary...

I believe runit is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to