Control: tags -1 +moreinfo

Colin,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Issue

dpkg: error processing archive /tmp/apt-dpkg-install-yWBdmU/5-qatlib-
service.deb (--unpack):
 new qatlib-service package pre-installation script subprocess returned error
exit status 127
Errors were encountered while processing:
 /tmp/apt-dpkg-install-yWBdmU/5-qatlib-service.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
E: Failed to process build dependencies
qat-service          FAIL badpkg
blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat-
dev_24.02.0-1_amd64.deb deb:libqat-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4-
dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0-
1_amd64.deb deb:libqat4
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0-
1_amd64.deb deb:libusdm-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0-
dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0-
1_amd64.deb deb:libusdm0
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
examples_24.02.0-1_amd64.deb deb:qatlib-examples
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
service_24.02.0-1_amd64.deb deb:qatlib-service
/home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc
badpkg: Test dependencies are unsatisfiable. A common reason is that your
testbed is out of date with respect to the archive, and you need to use a
current testbed or run apt-get update or use -U.
autopkgtest [14:35:33]: @@@@@@@@@@@@@@@@@@@@ summary
libqat-dev           FAIL badpkg
blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat-
dev_24.02.0-1_amd64.deb deb:libqat-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4-
dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0-
1_amd64.deb deb:libqat4
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0-
1_amd64.deb deb:libusdm-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0-
dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0-
1_amd64.deb deb:libusdm0
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
examples_24.02.0-1_amd64.deb deb:qatlib-examples
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
service_24.02.0-1_amd64.deb deb:qatlib-service
/home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc
badpkg: Test dependencies are unsatisfiable. A common reason is that your
testbed is out of date with respect to the archive, and you need to use a
current testbed or run apt-get update or use -U.
qat-service          FAIL badpkg
blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat-
dev_24.02.0-1_amd64.deb deb:libqat-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4-
dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0-
1_amd64.deb deb:libqat4
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0-
1_amd64.deb deb:libusdm-dev
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0-
dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0-
1_amd64.deb deb:libusdm0
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
examples_24.02.0-1_amd64.deb deb:qatlib-examples
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service-
dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym
arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-
service_24.02.0-1_amd64.deb deb:qatlib-service
/home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc
badpkg: Test dependencies are unsatisfiable. A common reason is that your
testbed is out of date with respect to the archive, and you need to use a
current testbed or run apt-get update or use -U.

E: Autopkgtest run failed.

2. Lintian [3]: Issue

W: qatlib-examples: national-encoding [usr/share/qat/calgary]
N: 
N:   A file is not valid UTF-8.
N:   
N:   Debian has used UTF-8 for many years. Support for national encodings is
N:   being phased out. This file probably appears to users in mangled
N:   characters (also called mojibake).
N:   
N:   Packaging control files must be encoded in valid UTF-8.
N:   
N:   Please convert the file to UTF-8 using iconv or a similar tool.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: files/encoding
N:   Renamed from: national-encoding-in-text-file
N:   debian-changelog-file-uses-obsolete-national-encoding
N:   debian-control-file-uses-obsolete-national-encoding
N:   debian-copyright-file-uses-obsolete-national-encoding
N:   debian-news-file-uses-obsolete-national-encoding
N:   debian-tests-control-uses-national-encoding
N:   doc-base-file-uses-obsolete-national-encoding
N:   national-encoding-in-debconf-template national-encoding-in-manpage

W: qatlib-examples: no-manual-page [usr/bin/algchaining_sample]
N: 
N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should
have
N:   a manual page
N:   
N:   Note that though the man program has the capability to check for several
N:   program names in the NAMES section, each of these programs should have
its
N:   own manual page (a symbolic link to the appropriate manual page is
N:   sufficient) because other manual page viewers such as xman or tkman
don't
N:   support this.
N:   
N:   If the name of the manual page differs from the binary by case, man may
be
N:   able to find it anyway; however, it is still best practice to match the
N:   exact capitalization of the executable in the manual page.
N:   
N:   If the manual pages are provided by another package on which this
package
N:   depends, Lintian may not be able to determine that manual pages are
N:   available. In this case, after confirming that all binaries do have
manual
N:   pages after this package and its dependencies are installed, please add
a
N:   Lintian override.
N: 
N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: binary-without-manpage
N: 
N:
W: qatlib-examples: no-manual-page [usr/bin/ccm_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/cipher_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/cpa_sample_code]
N:
W: qatlib-examples: no-manual-page [usr/bin/dc_dp_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/dc_stateless_multi_op_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/dc_stateless_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/dh_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/ec_montedwds_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/eddsa_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/gcm_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/hash_file_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/hash_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/hkdf_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/ipsec_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/prime_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/ssl_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/sym_dp_sample]
N:
W: qatlib-examples: no-manual-page [usr/bin/zuc_sample]

W: qatlib-service: script-with-language-extension [usr/sbin/qat_init.sh]
N: 
N:   When scripts are installed into a directory in the system PATH, the
script
N:   name should not include an extension such as .sh or .pl that denotes the
N:   scripting language currently used to implement it. The implementation
N:   language may change; if it does, leaving the name the same would be
N:   confusing and changing it would be disruptive.
N: 
N:   Please refer to Scripts (Section 10.4) in the Debian Policy Manual for
N:   details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: files/scripts

I: qatlib-examples: arch-dep-package-has-big-usr-share 5916kB 87%
N: 
N:   The package has a significant amount of architecture-independent data
N:   (over 4MB, or over 2MB and more than 50% of the package) in /usr/share
but
N:   is an architecture-dependent package. This is wasteful of mirror space
and
N:   bandwidth since it means distributing multiple copies of this data, one
N:   for each architecture.
N:   
N:   If the data in /usr/share is not architecture-independent, this is a
N:   Policy violation that should be fixed by moving the data elsewhere
N:   (usually /usr/lib).
N: 
N:   Please refer to Section 6.7.5 of the Debian Developer's Reference for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: huge-usr-share

I: libqat4: spelling-error-in-binary suppported supported [usr/lib/x86_64-
linux-gnu/libqat.so.4.2.0]
N: 
N:   Lintian found a spelling error in the given binary. Lintian has a list
of
N:   common misspellings that it looks for. It does not have a dictionary
like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help
of
N:   gettext or a similar tool, please fix the error in the translations as
N:   well as the English text to avoid making the translations fuzzy. With
N:   gettext, for example, this means you should also fix the spelling
mistake
N:   in the corresponding msgids in the *.po files.
N:   
N:   You can often find the word in the source code by running:
N:   
N:    grep -rw <word> <source-tree>
N:   
N:   This tag may produce false positives for words that contain non-ASCII
N:   characters due to limitations in strings.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/spelling

I: qatlib-examples: spelling-error-in-binary wtH with
[usr/bin/cpa_sample_code]
N:
I: qatlib-service: systemd-service-file-missing-documentation-key
[lib/systemd/system/qat.service]
N: 
N:   The systemd service file does not contain a Documentation key.
N:   
N:   Documentation for systemd service files can be automatically viewed
using
N:   systemctl help servicename if this field is present.
N: 
N:   Please refer to the systemd.unit(5) manual page for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: systemd

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe qatlib is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to