Thomas,

AN updated review with latest tests and unstable tree packages.

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Issue

autopkgtest [13:48:08]: test simple-test: [-----------------------

System information as of Tue Aug  6 12:48:08 UTC 2024
tput: No value for $TERM and no -T specified
env: ‘uptime’: No such file or directory
/usr/bin/System-Info: line 62: ps: command not found
env: ‘free’: No such file or directory
find: ‘/etc/ssh’: No such file or directory

Host:             ks-tarkin
Uptime:            hours
Operating System: Debian GNU/Linux  with kernel 6.9.12-amd64
Processor:        4 × x86_64; 0 processes; 0 users
Load:             
Used Memory:           0 MiB of      0 MiB (     0 MiB available)
Used Swap:        no swap available!
Used Diskspace:   8% on /, 8% on /home
/usr/bin/System-Info: line 250: ip: command not found
/usr/bin/System-Info: line 250: ip: command not found
/usr/bin/System-Info: line 286: ip: command not found
Network:


System information as of Tue Aug  6 12:48:09 UTC 2024
tput: No value for $TERM and no -T specified
env: ‘uptime’: No such file or directory
/usr/bin/System-Info: line 62: ps: command not found
env: ‘free’: No such file or directory
find: ‘/etc/ssh’: No such file or directory

Host:             ks-tarkin
Uptime:            hours
Operating System: Debian GNU/Linux  with kernel 6.9.12-amd64
Processor:        4 × x86_64; 0 processes; 0 users
Load:             
Used Memory:           0 MiB of      0 MiB (     0 MiB available)
Used Swap:        no swap available!
Used Diskspace:   8% on /, 8% on /home
/usr/bin/System-Info: line 250: ip: command not found
/usr/bin/System-Info: line 250: ip: command not found
/usr/bin/System-Info: line 286: ip: command not found
Network:

Test passed!
autopkgtest [13:48:09]: test simple-test: -----------------------]
autopkgtest [13:48:09]: test simple-test:  - - - - - - - - - - results - - -
- - - - - - -
simple-test          FAIL stderr: tput: No value for $TERM and no -T
specified
autopkgtest [13:48:09]: test simple-test:  - - - - - - - - - - stderr - - - -
- - - - - -
tput: No value for $TERM and no -T specified
env: ‘uptime’: No such file or directory
/usr/bin/System-Info: line 62: ps: command not found
env: ‘free’: No such file or directory
find: ‘/etc/ssh’: No such file or directory
autopkgtest [13:48:09]: @@@@@@@@@@@@@@@@@@@@ summary
simple-test          FAIL stderr: tput: No value for $TERM and no -T
specified

E: Autopkgtest run failed.

2. Lintian [3]: Issue

I: td-system-info: ored-depends-on-obsolete-package Depends: bsdmainutils =>
bsdextrautils and/or ncal
N: 
N:   The package depends on an ORed group of packages which includes a
package
N:   that has been superseded.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/package-relations

I: td-system-tools source: out-of-date-standards-version 4.6.2 (released
2022-12-17) (current is 4.7.0)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider
updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you
don't
N:   have to re-upload the package just to adjust the Standards-Version
control
N:   field. However, please remember to update this field next time you
upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

 dpkg-source --before-build .
 debian/rules clean
dh clean --buildsystem=cmake
   dh_auto_clean -O--buildsystem=cmake
   dh_autoreconf_clean -O--buildsystem=cmake
   dh_clean -O--buildsystem=cmake
 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: verifying ./td-system-tools_1.7.0.orig.tar.xz.asc
dpkg-source: info: building td-system-tools using existing ./td-system-
tools_1.7.0.orig.tar.xz
dpkg-source: info: building td-system-tools using existing ./td-system-
tools_1.7.0.orig.tar.xz.asc
dpkg-source: warning: newly created empty file 'po/de/.Fingerprint-SSH-
Keys.po.stamp' will not be represented in diff
dpkg-source: warning: newly created empty file 'po/de/.Reset-Machine-
ID.po.stamp' will not be represented in diff
dpkg-source: warning: newly created empty file 'po/de/.System-Info.po.stamp'
will not be represented in diff
dpkg-source: warning: newly created empty file 'po/de/.System-
Maintenance.po.stamp' will not be represented in diff
dpkg-source: error: cannot represent change to po/de/LC_MESSAGES/Fingerprint-
SSH-Keys.mo: binary file contents changed
dpkg-source: error: add po/de/LC_MESSAGES/Fingerprint-SSH-Keys.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/de/LC_MESSAGES/Reset-
Machine-ID.mo: binary file contents changed
dpkg-source: error: add po/de/LC_MESSAGES/Reset-Machine-ID.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/de/LC_MESSAGES/System-
Info.mo: binary file contents changed
dpkg-source: error: add po/de/LC_MESSAGES/System-Info.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/de/LC_MESSAGES/System-
Maintenance.mo: binary file contents changed
dpkg-source: error: add po/de/LC_MESSAGES/System-Maintenance.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: warning: newly created empty file 'po/nb/.Fingerprint-SSH-
Keys.po.stamp' will not be represented in diff
dpkg-source: warning: newly created empty file 'po/nb/.Reset-Machine-
ID.po.stamp' will not be represented in diff
dpkg-source: warning: newly created empty file 'po/nb/.System-Info.po.stamp'
will not be represented in diff
dpkg-source: warning: newly created empty file 'po/nb/.System-
Maintenance.po.stamp' will not be represented in diff
dpkg-source: error: cannot represent change to po/nb/LC_MESSAGES/Fingerprint-
SSH-Keys.mo: binary file contents changed
dpkg-source: error: add po/nb/LC_MESSAGES/Fingerprint-SSH-Keys.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/nb/LC_MESSAGES/Reset-
Machine-ID.mo: binary file contents changed
dpkg-source: error: add po/nb/LC_MESSAGES/Reset-Machine-ID.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/nb/LC_MESSAGES/System-
Info.mo: binary file contents changed
dpkg-source: error: add po/nb/LC_MESSAGES/System-Info.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to po/nb/LC_MESSAGES/System-
Maintenance.mo: binary file contents changed
dpkg-source: error: add po/nb/LC_MESSAGES/System-Maintenance.mo in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env 
I: removing directory /var/cache/pbuilder/build/60783 and its subdirectories

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe td-system-tools is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to