Control: tags -1 -moreinfo Control: tags -1 +confirmed Hi Xiyue,
As this has been ongoing, we can confirm the package for DD review and know
it is on the to do list for looking at in the future.
Regards
Phil
On Sun, 2024-08-04 at 16:15 -0700, Xiyue Deng wrote:
> Hi Phil,
>
> Thanks for the report. Please see below inline.
>
> Phil Wyett <philip.wy...@kathenas.org> writes:
>
> > [[PGP Signed Part:Undecided]]
> > Control: tags -1 + moreinfo
> >
> > Xiyue,
> >
> > Preamble...
> >
> > Thank you for taking the time to prepare this package and your contribution
> > to the Debian project.
> >
> > The review below is for assistance. This review is offered to help package
> > submitters to Debian mentors inorder to improve their packages prior to
> > possible sponsorship into Debian. There is no obligation on behalf of the
> > submitter to make any alterations based upon information provided in the
> > review.
> >
> > Review...
> >
> > 1. Build:
> >
> > * pbuilder [1]: Good
> > * sbuild [2]: Good
> >
> > 2. Lintian [3]: Good
> >
> > 3. Licenses [4]: Good
> >
> > 4. Watch file [uscan --force-download]: Good
> >
> > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
> >
> > 6. Reproducible builds [5]: Issue
> >
> > dh_elpa_test
> > create-stamp debian/debhelper-build-stamp
> > dh_prep
> > dh_install
> > dh_elpa
> > dh_elpa: warning: missing muse-pkg.el; will try to generate it
> > dh_installdocs
> > debian/rules override_dh_installchangelogs
> > make[1] : on entre dans le répertoire
> > « /tmp/reprotest.8iYuEi/const_build_path/const_build_path »
> > cat ChangeLog ChangeLog.5 ChangeLog.4 ChangeLog.3 ChangeLog.2 ChangeLog.1 >
> > debian/.debhelper/changelog
> > dh_installchangelogs debian/.debhelper/changelog
> > make[1] : on quitte le répertoire
> > « /tmp/reprotest.8iYuEi/const_build_path/const_build_path »
> > dh_installexamples
> > dh_lintian
> > dh_perl
> > dh_link
> > dh_strip_nondeterminism
> > debian/rules override_dh_compress
> > make[1] : on entre dans le répertoire
> > « /tmp/reprotest.8iYuEi/const_build_path/const_build_path »
> > dh_compress -X.pdf
> > make[1] : on quitte le répertoire
> > « /tmp/reprotest.8iYuEi/const_build_path/const_build_path »
> > dh_fixperms
> > dh_missing
> > dh_installdeb
> > dh_gencontrol
> > dh_md5sums
> > dh_builddeb
> > dpkg-deb: construction du paquet « elpa-muse » dans « ../elpa-
> > muse_3.20+git20240209.8710add+dfsg-1_all.deb ».
> > dpkg-genbuildinfo --build=binary
> > -O../muse-el_3.20+git20240209.8710add+dfsg-
> > 1_amd64.buildinfo
> > dpkg-genchanges --build=binary -O../muse-el_3.20+git20240209.8710add+dfsg-
> > 1_amd64.changes
> > dpkg-genchanges: info: binary-only upload (no source code included)
> > dpkg-source --after-build .
> > dpkg-buildpackage: info: binary-only upload (no source included)
> > --- /tmp/tmpru2ecytu/control
> > +++ /tmp/tmpru2ecytu/experiment-user_group
> > │ --- /tmp/tmpru2ecytu/control/source-root
> > ├── +++ /tmp/tmpru2ecytu/experiment-user_group/source-root
> > │ │ --- /tmp/tmpru2ecytu/control/source-root/elpa-
> > muse_3.20+git20240209.8710add+dfsg-1_all.deb
> > │ ├── +++ /tmp/tmpru2ecytu/experiment-user_group/source-root/elpa-
> > muse_3.20+git20240209.8710add+dfsg-1_all.deb
> > │ │ ├── file list
> > │ │ │ @@ -1,3 +1,3 @@
> > │ │ │ -rw-r--r-- 0 0 0 4 2024-08-04 11:01:37.000000
> > debian-binary
> > │ │ │ -rw-r--r-- 0 0 0 3180 2024-08-04 11:01:37.000000
> > control.tar.xz
> > │ │ │ +-rw-r--r-- 0 0 0 286912 2024-08-04 11:01:37.000000
> > data.tar.xz
> > │ │ │ --rw-r--r-- 0 0 0 286896 2024-08-04 11:01:37.000000
> > data.tar.xz
> > │ │ ├── control.tar.xz
> > │ │ │ ├── control.tar
> > │ │ │ │ ├── ./control
> > │ │ │ │ │ @@ -1,13 +1,13 @@
> > │ │ │ │ │ Package: elpa-muse
> > │ │ │ │ │ Source: muse-el
> > │ │ │ │ │ Version: 3.20+git20240209.8710add+dfsg-1
> > │ │ │ │ │ Architecture: all
> > │ │ │ │ │ Maintainer: Debian Emacsen Team <debian-emac...@lists.debian.org>
> > │ │ │ │ │ +Installed-Size: 902
> > │ │ │ │ │ -Installed-Size: 901
> > │ │ │ │ │ Depends: dh-elpa-helper, emacsen-common, elpa-htmlize
> > │ │ │ │ │ Recommends: emacs, doc-base, texlive-latex-base
> > │ │ │ │ │ Enhances: emacs
> > │ │ │ │ │ Breaks: muse-el (<< 3.20+dfsg-5)
> > │ │ │ │ │ Replaces: muse-el (<< 3.20+dfsg-5)
> > │ │ │ │ │ Provides: muse-el
> > │ │ │ │ │ Section: editors
> > │ │ │ │ ├── ./md5sums
> > │ │ │ │ │ ├── ./md5sums
> > │ │ │ │ │ │┄ Files differ
> > │ │ ├── data.tar.xz
> > │ │ │ ├── data.tar
> > │ │ │ │ ├── file list
> > │ │ │ │ │ @@ -52,15 +52,15 @@
> > │ │ │ │ │ drwxr-xr-x 0 root (0) root (0) 0
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/
> > │ │ │ │ │ drwxr-xr-x 0 root (0) root (0) 0
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/
> > │ │ │ │ │ drwxr-xr-x 0 root (0) root (0) 0
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/
> > │ │ │ │ │ drwxr-xr-x 0 root (0) root (0) 0
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 7657
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/cgi.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 1624
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/htmlize-
> > hack.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 9807
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/httpd.el
> > │ │ │ │ │ +-rw-r--r-- 0 root (0) root (0) 13383
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > autoloads.el
> > │ │ │ │ │ --rw-r--r-- 0 root (0) root (0) 13273
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > autoloads.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 12128
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > backlink.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 11597
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > blosxom.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 11497
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > book.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 4768
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > cite.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 42210
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > colors.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 16614
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > context.el
> > │ │ │ │ │ -rw-r--r-- 0 root (0) root (0) 13691
> > 2024-08-
> > 04 11:01:37.000000 ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > docbook.el
> > │ │ │ │ ├── ./usr/share/emacs/site-lisp/elpa-src/muse-3.20.2/muse-
> > autoloads.el
> > │ │ │ │ │ @@ -431,14 +431,19 @@
> > │ │ │ │ │ (register-definition-prefixes "muse-xml-common" '("muse-xml-"))
> > │ │ │ │ │
> > │ │ │ │ │ ;;;***
> > │ │ │ │ │
> >
> > │ │ │ │ │ ;;;### (autoloads nil nil ("../contrib/htmlize-hack.el") (0 0 0
> > 0))
> > │ │ │ │ │
> > │ │ │ │ │ ;;;***
> > │ │ │ │ │ +
> > │ │ │ │ │ +
> >
> > │ │ │ │ │ +;;; Generated autoloads from muse-latex2png.el
> > │ │ │ │ │ +
> > │ │ │ │ │ +(register-definition-prefixes "muse-latex2png" '("muse-"))
> > │ │ │ │ │
> >
> > │ │ │ │ │ ;;;### (autoloads nil "muse-backlink" "muse-backlink.el" (0 0 0
> > 0))
> > │ │ │ │ │ ;;; Generated autoloads from muse-backlink.el
> > │ │ │ │ │
> > │ │ │ │ │ (register-definition-prefixes "muse-backlink"
> > '("muse-backlink-"))
> > │ │ │ │ │
> > │ │ │ │ │ ;;;***
> > Observed unreproducibility when varying each of the following:
> > timezone fileordering user_group
> > The build is probably reproducible when varying other things.
> >
>
> This seems to be a known issue with dblatex[1][2], and exists in
> previous versions as well (stable and testing). I wouldn't consider
> this a blocking issue yet as Debian has not mandated reproducible build
> as release criteria yet. Cab we consider this package ready for now
> while we work on a fix?
>
> > 7. Install [No previous installs]: Good
> >
> > 8. Upgrade [Over previous installs if any]: Good
> >
> > Summary...
> >
> > I believe muse-el is not yet ready for sponsorship/upload. Could the
> > contributor rectify one of more of the rasied issues. Once updated to your
> > satisfaction and a new upload done, please remove the 'moreinfo' on the
> > Request For Sponsorship (RFS) bug report.
> >
> > Regards
> >
> > Phil
> >
> > [1] pbuilder:
> >
> > * Command: sudo pbuilder build <PACKAGE>.dsc
> > * Document: https://wiki.ubuntu.com/PbuilderHowto.
> > * Document: https://wiki.debian.org/PbuilderTricks
> >
> > [2] sbuild:
> >
> > * Command: sbuild <PACKAGE>.dsc
> > * Document: https://wiki.debian.org/sbuild
> >
> > [3] lintian:
> >
> > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> > *.changes, *.buildinfo). Each can throw up different results, so be
> > thorough.
> > * Document: https://wiki.debian.org/Lintian
> >
> > [4] lrc:
> >
> > * Command: lrc -t
> > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
> >
> > [5] reprotest
> >
> > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1
> > --auto-
> > build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
> > * Document: https://wiki.debian.org/ReproducibleBuilds/
> > * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
> >
> > --
> >
> > "I play the game for the game’s own sake"
> >
> > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
> >
> > --
> >
> > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
> >
> > Internet Relay Chat (IRC): kathenas
> >
> > Matrix: #kathenas:matrix.org
> >
> > Website: https://kathenas.org
> >
> > Instagram: https://instagram.com/kathenasorg/
> >
> > Threads: https://www.threads.net/@kathenasorg
>
> [1]
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/muse-el.html
> [2]
> https://tests.reproducible-builds.org/debian/issues/unstable/random_id_in_pdf_generated_by_dblatex_issue.html
>
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
