Control: tags -1 + confirmed Alexandre,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Good 3. Licenses [4]: Issue philwyett@ks-solo:~/Development/builder/debian/mentoring/adminer-4.8.1$ lrc - t : Versions: recon 1.14 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck Apache-2.0 | Expat designs/rmsoft/adminer.css You stated in a previous bug entry that this was a false positive, but it is not. Below is the license title line from the file. I think we can let this one go until your next update of the package as this has been in the archive for a while. * @license MIT: http://mit-license.org/ 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe adminer is ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part