Control: tags -1 + moreinfo Dong,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue W: nvidia-vaapi-driver source: nmu-in-changelog [debian/changelog:1] N: N: The first line of the changelog entry for this package appears to indicate N: it is a non-maintainer upload (by including either that string or the N: string "NMU" and not saying that it's an acknowledgement), but the N: changelog indicates the person making this release is one of the N: maintainers. N: N: If this was intended to be an NMU, do not add yourself as a maintainer or N: uploader. Otherwise, please rephrase your changelog entry to not cause N: confusion. N: N: Visibility: warning N: Show-Always: no N: Check: nmu N: Renamed from: changelog-should-not-mention-nmu N: This is an NMU only and not an adoption of the package. The maintainer is not changing so should be reinstated. W: nvidia-vaapi-driver source: no-debian-changes N: N: This non-native package makes no changes to the upstream sources in the N: Debian-related files. N: N: Maybe a mistake was made when the upstream tarball was created, or maybe N: this package is really a native package but was built non-native by N: mistake. N: N: Debian packaging is sometimes maintained as part of upstream, but that is N: not recommended as best practice. Please make this package native, if the N: software is only for Debian. Otherwise, please remove the debian directory N: from upstream releases and add it in the Debian packaging. N: N: Format 1.0 packages are subject to the restriction that the diff cannot N: remove files from the debian directory. For Format 3.0 packages, the N: debian directory is automatically purged during unpacking. N: N: Visibility: warning N: Show-Always: no N: Check: files/artifact N: Renamed from: empty-debian-diff N: I: nvidia-vaapi-driver: spelling-error-in-binary destory destroy [usr/lib/x86_64-linux-gnu/dri/nvidia_drv_video.so] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe nvidia-vaapi-driver is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
