Control: tags -1 moreinfo Hi, a short review: - You're repacking the source. It's not clear to me why you are removing the files. Can you expand?
- d/patches: (more a hint, as maintaining patches in Debian will cause extra work down the road for you…): Please consider upstream the patches, the write-to-userdir and the use-system-zlib might be candidates. As serious-source is using CMake, the use-system-zlib patch could be rewritten that CMake is looking for the system's zlib, and if it is found use that, otherwise add the bundled zlib to the include path. (For illustration, I did something similar recently: https://github.com/codereader/DarkRadiant/pull/43) - (Another hint) Please upstream the manpages. - What is the copyright of the logos (debian/*svg)? Where are they from? - (optional) Please add a repository for the packaging on salsa, maybe even under the games team umbrella? (I can create one for you, if you want to go that route.) The README says: Running ------- This version of the engine comes with a set of resources (`\SE1_10.GRO`) that allow you to freely use the engine without any additional resources required. However if you want to open or modify levels from Serious Sam Classic: The First Encounter or The Second Encounter (including most user-made levels), you will have to copy the game's resources (.GRO files) into the engine folder. You can buy the original games on Steam, as a part of a bundle with Serious Sam Revolution ( http://store.steampowered.com/app/227780 ) - Are the resources mentioned redistributeable or even DFSG licensed? - The README also mentions level editors. Do they compile for linux? If both could be answered yes, your package could go into main. -- tobi On Thu, May 30, 2024 at 07:34:07PM +0200, Sébastien Noel wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "serious-engine": > > * Package name : serious-engine > Version : 0~git20230724+dfsg-1 > Upstream contact : https://github.com/ptitSeb/Serious-Engine/issues > * URL : https://www.croteam.com/serious-sam-source-code-released/ > * License : GPL-2 > * Vcs : https://salsa.debian.org/twolife/serious-engine > Section : contrib/games > > The source builds the following binary packages: > > serious-sam-tfe - Serious Sam - The First Encounter > serious-sam-tse - Serious Sam - The Second Encounter > > To access further information about this package, please visit the > following URL: > > https://mentors.debian.net/package/serious-engine/ > > Alternatively, you can download the package with 'dget' using this > command: > > dget -x > https://mentors.debian.net/debian/pool/contrib/s/serious-engine/serious-engine_0~git20230724+dfsg-1.dsc > > Changes for the initial release: > > serious-engine (0~git20230724+dfsg-1) unstable; urgency=low > . > * Initial release. Closes: #1034630 > > > This package alone isn't of any use; it only contains the game engine, > an engine that has no Free data and therefore is in contrib. > You will need a copy of the original game for this package to be > useful. > Please use game-data-packager to build a .deb of proprietary data (gog > or steam) to unleash the full potential of this code. > > Best Regards, > Sébastien >
