Xiyue, Preamble...
Thank you for taking the time to create this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Good
3. Licenses (lrc[3]): Issue
A minor. It would be nice if the contributors if contacted would be willing
to change the license to match the rest of the package.
philwyett@ks-solo:~/Development/builder/debian/mentoring/debian-el-37.14$ lrc
: Versions: recon 1.12 check 3.3.9-1
Parsing Source Tree ....
Reading copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | GPL apt-sources.el
4. Watch file (uscan --force-download): N/A
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]: Issue, not a blocker
Something worth investigation, but not a blocker
dpkg-deb: building package 'debian-el' in '../debian-el_37.14_all.deb'.
dpkg-deb: building package 'elpa-debian-el' in '../elpa-debian-
el_37.14_all.deb'.
dpkg-genbuildinfo --build=binary -O../debian-el_37.14_amd64.buildinfo
dpkg-genchanges --build=binary -O../debian-el_37.14_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
Observed unreproducibility when varying each of the following:
locales
The build is probably reproducible when varying other things.
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): Good
Summary...
I believe debian-el is ready for sponsorship/upload. Could a Debian Developer
(DD) with available free time, please review this package and upload if you
feel it is ready.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
