Soren, Thank you very much for sponsoring astro.
I'll remember to align the debian/* files with the Expat license in a future release, to facilitate potential upstream contributions as you mentioned.
Regarding your suggestion about becoming a Debian Maintainer, I am very interested in taking this step to contribute more actively to the Debian project.
Thanks & Regards, Akash Doppalapudi On 7/18/24 2:17 AM, Soren Stoutner wrote:
Akash,I have sponsored astro. As Phill said, this package is in excellent shape.I noticed that upstream uses the Expat (MIT) license, but that you chose to license debian/* as GPL-2+. It is generally considered good practice to use the same license for debian/* as upstream, so that any patches or other information in debian/* can be submitted upstream if it ever makes sense to do so. This is not a hard requirement and you are certainly free to license debian/* under the GPL-2+ if you feel strongly it should be so. But you might consider changing the license to Expat in a future release.Based on the quality of your packaging, I would recommend you consider becoming a Debian Maintainer.https://wiki.debian.org/DebianMaintainer Soren On Wednesday, July 17, 2024 11:09:22 AM MST Akash Doppalapudi wrote: > Thank you Soren and Phil for reviewing this package. > > -- > Akash Doppalapudi > > On 7/17/24 11:22 PM, Soren Stoutner wrote: > > > Akash, > > > > > > > > I will review your package for sponsorship. > > > > > > > > On Tuesday, July 16, 2024 7:09:36 PM MST Phil Wyett wrote: > > > >> Akash, > >> > >> > >> > >> Preamble... > >> > >> > >>> >> Thank you for taking the time to create this package and your contribution> >> to the Debian project. > >> > >> > >> > >> The review below is for assistance. This review is offered to help> >> package submitters to Debian mentors inorder to improve their packages> >> prior to possible sponsorship into Debian. There is no obligation on > >> behalf> >> of the submitter to make any alterations based upon information provided> >> in the review. > >> > >> > >> > >> Review... > >> > >> > >> > >> 1. Build[1]: Good > >> > >> > >> > >> 2. Lintian[2]: Good > >> > >> > >> > >> 3. Licenses (lrc[3]): Good > >> > >> > >> > >> 4. Watch file (uscan --force-download): Good > >> > >> > >> > >> 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good > >> > >> > >> > >> 6. Reproducible builds (reporotest)[3]: Good > >> > >> > >> > >> 7. Install (No previous installs): Good > >> > >> > >> > >> 8. Upgrade (Over previous installs if any): N/A > >> > >> > >> > >> Summary... > >> > >> > >> > >> This is an initial submission of a very high quality - Excellent work > >> Akash= > > > > -- Soren Stoutner so...@debian.org
OpenPGP_0xBCBCAE31ECE05007.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
