Alexander,

Preamble...

Thank you for taking the time to create this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.

Review...

1. Build[1]: Good

2. Lintian[2]: Minor

I: task-spooler source: anticipated-repack-count 1.0.3+dfsg1-1
N: 
N:   The version contains the string +dfsgN where N is a low number as in
N:   +dfsg1.
N:   
N:   Normally it is not necessary to repackage an upstream source package
more
N:   than once. You can omit the repack count. In most cases +dfsg-1 is
enough.
N:   
N:   If you really need to bump it, just go straight to +dfsg2-1.
N: 
N:   Please refer to
N:   https://lists.debian.org/debian-devel/2021/10/msg00026.html for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/version/repack/count

3. Licenses (lrc[3]): Good

4. Watch file (uscan --force-download): Good

5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

6. Reproducible builds (reporotest)[3]: Good

7. Install (No previous installs): Good

8. Upgrade (Over previous installs if any): Good

Summary...

The lintian is an informational one, but something to take note of for the
future.

I believe task-spooler is ready for sponsorship/upload. Could a Debian
Developer (DD) with available free time, please review this package and
upload if you feel it is ready.

Regards

Phil

[1] Using:
      * pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
      * https://wiki.debian.org/PbuilderTricks
    and
      * sbuild - https://wiki.debian.org/sbuild.

[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
    *.changes, *.buildinfo). Each can throw up different, so be thorough.

[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.

[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to