Control: tags -1 + moreinfo Jeremy,
Preamble... Thank you for taking the time to create this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Issue With pbuilder: gmsh not found, skipping test SKIP tests/wilson.sh (exit status: 77) ============================================================================ Testsuite summary for feenox 1.0.63 ============================================================================ # TOTAL: 75 # PASS: 20 # SKIP: 26 # XFAIL: 6 # FAIL: 23 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to jer...@seamplex.com ============================================================================ make[4]: *** [Makefile:1783: test-suite.log] Error 1 make[4]: Leaving directory '/build/feenox-1.0.63' make[3]: *** [Makefile:1891: check-TESTS] Error 2 make[3]: Leaving directory '/build/feenox-1.0.63' make[2]: *** [Makefile:2645: check-am] Error 2 make[2]: Leaving directory '/build/feenox-1.0.63' make[1]: *** [Makefile:1668: check-recursive] Error 1 make[1]: Leaving directory '/build/feenox-1.0.63' dh_auto_test: error: make -j4 check "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:4: binary] Error 255 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build/90208 and its subdirectories 2. Lintian[2]: Issue W: feenox source: upstream-metadata-yaml-invalid mapping values are not allowed in this context (at document 1, line 7, column 16) [debian/upstream/metadata] N: N: The DEP 12 metadata file is not well formed. The formatting need to be N: adjusted to match the YAML specification. N: N: Please refer to https://dep-team.pages.debian.net/deps/dep12/ for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/upstream/metadata N: N: I: feenox source: debian-watch-file-is-missing N: N: This source package is not Debian-native but it does not have a N: debian/watch file. This file is used for automatic detection of new N: upstream versions by the Debian External Health Status project and other N: project infrastructure. If this package is maintained upstream, please N: consider adding a debian/watch file to detect new releases. N: N: If the package is not maintained upstream or if upstream uses a N: distribution mechanism that cannot be meaningfully monitored by uscan and N: the Debian External Health Status project, please consider adding a N: debian/watch file containing only comments documenting the situation. N: N: Please refer to Upstream source location: debian/watch (Section 4.11) in N: the Debian Policy Manual and the uscan(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/watch N: N: I: feenox: extra-license-file [usr/share/doc/feenox/COPYING.gz] N: N: All license information should be collected in the debian/copyright file. N: This usually makes it unnecessary for the package to install this N: information in other places as well. N: N: Please refer to Copyright information (Section 12.5) in the Debian Policy N: Manual for details. N: N: Visibility: info N: Show-Always: no N: Check: files/licenses N: N: I: feenox: file-references-package-build-path [usr/bin/feenox] N: N: The listed file or maintainer script appears to reference the build path N: used to build the package as specified in the Build-Path field of the N: .buildinfo file. N: N: This is likely to cause the package to be unreproducible, but it may also N: indicate that the package will not work correctly outside of the N: maintainer's own system. N: N: Please note that this tag will not appear unless the .buildinfo file N: contains a Build-Path field. That field is optional. You may have to set N: DEB_BUILD_OPTIONS=buildinfo=+path or use N: --buildinfo-option=--always-include-path with dpkg-buildpackage when N: building. N: N: Please refer to https://reproducible-builds.org/, N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the N: dpkg-genbuildinfo(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: files/contents N: N: I: feenox: hardening-no-bindnow [usr/bin/feenox] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: feenox source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.6.2) N: N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the N: timestamp of the latest debian/changelog entry). Please consider updating N: the package to current Policy and setting this control field N: appropriately. N: N: If the package is already compliant with the current standards, you don't N: have to re-upload the package just to adjust the Standards-Version control N: field. However, please remember to update this field next time you upload N: the package. N: N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the N: debian-policy package for a summary of changes in newer versions of N: Policy. N: N: Please refer to N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for N: details. N: N: Visibility: info N: Show-Always: no N: Check: fields/standards-version N: N: I: feenox: spelling-error-in-binary assigment assignment [usr/bin/feenox] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: feenox: spelling-error-in-binary commmand-line command-line [usr/bin/feenox] N: I: feenox: spelling-error-in-binary funcions functions [usr/bin/feenox] N: I: feenox: spelling-error-in-binary intial initial [usr/bin/feenox] N: I: feenox: spelling-error-in-binary neede needed [usr/bin/feenox] N: I: feenox: spelling-error-in-binary paramters parameters [usr/bin/feenox] N: I: feenox: spelling-error-in-binary unkown unknown [usr/bin/feenox] N: I: feenox: typo-in-manual-page compatiblity compatibility [usr/share/man/man1/feenox.1.gz:359] N: N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext (with the help of po4a, for example) or a similar tool, please fix N: the error in the translations as well as the English text to avoid making N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po N: files. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: spelling-error-in-manpage N: N: I: feenox: typo-in-manual-page dependend dependent [usr/share/man/man1/feenox.1.gz:977] N: I: feenox: typo-in-manual-page explictly explicitly [usr/share/man/man1/feenox.1.gz:357] N: I: feenox: typo-in-manual-page explictly explicitly [usr/share/man/man1/feenox.1.gz:741] N: I: feenox: typo-in-manual-page expresions expressions [usr/share/man/man1/feenox.1.gz:389] N: I: feenox: typo-in-manual-page expresssions expressions [usr/share/man/man1/feenox.1.gz:822] N: I: feenox: typo-in-manual-page openened opened [usr/share/man/man1/feenox.1.gz:285] N: I: feenox: typo-in-manual-page preceeding preceding [usr/share/man/man1/feenox.1.gz:1043] N: I: feenox: typo-in-manual-page representaion representation [usr/share/man/man1/feenox.1.gz:1489] N: I: feenox: typo-in-manual-page wheter whether [usr/share/man/man1/feenox.1.gz:1141] 3. Licenses (lrc[3]): Not performed at this time 4. Watch file (uscan --force-download): Not performed at this time 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Not performed at this time 6. Reproducible builds (reporotest)[3]: Not performed at this time 7. Install (No previous installs): Not performed at this time 8. Upgrade (Over previous installs if any): N/A Summary... I believe feenox is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] Using: * pbuilder - https://wiki.ubuntu.com/PbuilderHowto. * https://wiki.debian.org/PbuilderTricks and * sbuild - https://wiki.debian.org/sbuild. [2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] 'lrc' from 'licenserecon' is located in Debian testing and newer. [4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
