Control: tags -1 - moreinfo On Sun, 14 Jul 2024 at 00:36, Phil Wyett <philip.wy...@kathenas.org> wrote: > > Control: tags -1 + moreinfo > > Christian, > > Updated full review with all tests.
Many thanks for your review. > Preamble... > > Thank you for taking the time to create this package and your contribution to > the Debian project. > > The below review is for assistance. It is offered to help submitters of > packages to Debian mentors improve their packages prior to possible > sponsorship into Debian. There is no obligation on behalf of the submitter to > make any alterations based upon information provided in the review. > > Review... > > 1. Build[1]: Issue > > dpkg-genchanges: info: including full source code in upload > I: copying local configuration > I: Copying back the cached apt archive contents > I: unmounting dev/ptmx filesystem > I: unmounting dev/pts filesystem > I: unmounting dev/shm filesystem > I: unmounting proc filesystem > I: unmounting sys filesystem > W: Stray processes left from build: > * system-pbuilder-build-logrotate_3.22.0\x2d1-55721.slice - Slice > /system/pbuilder/build/logrotate_3.22.> > Loaded: loaded > Active: active since Sat 2024-07-13 23:18:16 BST; 31s ago > Invocation: 30c1ef25f49e40afa5a5120b13732416 > Tasks: 5 > Memory: 278.9M (peak: 395.1M) > CPU: 32.996s > CGroup: /system.slice/system-pbuilder.slice/system-pbuilder- > build.slice/system-pbuilder-build-logro> > `-run-r0d9b46f0daed44e4a12eedd5b01acc7c.scope > |-64587 /build/logrotate-3.22.0/logrotate -v -m ./mailer -s > state test-config.87 -f > |-64591 sh -c "\n sleep 8\n" logrotate_script > /build/logrotate-3.22.0/test/test-00> > |-64593 sleep 8 > |-64917 flock state -c "sleep 10" > `-64919 sleep 10 > > Jul 13 23:18:16 ks-windu systemd[1]: Created slice system-pbuilder-build- > logrotate_3.22.0\x2d1-55721.sli> > lines 1-16/16 (END) These stray processes should be waited for in the latest mentors upload/with the latest commits. > 2. Lintian[2]: Good > > 3. Licenses (lrc): Good > > 4. Watch file (uscan --force-download): Good > > 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Not performed at > this time due to (1. Build). > > 6. Reproducible builds (reporotest)[3]: Not performed at this time due to (1. > Build) > > 7. Install (No previous installs): Not performed at this time due to (1. > Build) > > 8. Upgrade (Over previous installs if any): Not performed at this time due to > (1. Build) > > Summary... > > I believe logrotate is not yet ready for sponsorship/upload. Could the > contributor rectify one of more of the rasied issues. Once updated to your > satisfaction and a new upload done, please remove the 'moreinfo' on the > Request For Sponsorship (RFS) bug report. > > [1] Using pbuilder and sbuild. > > [2] lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, > *.buildinfo). Each can throw up different, so be thorough. > > [3] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method > > Regards > > Phil > > -- > > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Internet Relay Chat (IRC): kathenas > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > -- >
