Alan,

A little time has passed, so I will do an updated review to look for new things
and anything I missed.

Preamble...

Thank you for taking the time to create this package and your contribution to
the Debian project.

The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the submitter to
make any alterations based upon information provided in the review.

Review...

1. Build[1]: Good

2. Lintian[2]: Good

3. Licenses (lrc): Good

4. Watch file (uscan --force-download): Good

5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

6. Reproducible builds (reporotest)[3]: Good

7. Install (No previous installs): Good

8. Upgrade (Over previous installs if any): N/A

Additional...

A. Please update the 'Standards-Version' in 'debian/control' to latest 4.7.0 as
per Debian policy[4].

B. Disable 'export DH_VERBOSE = 1' in 'debian/rules'.

Summary...

I do believe your good work and the package is ready, but could you update for
the additional points mentioned and do an upload before a DD looks at the
package.

I believe libhyprcursor is ready for sponsorship/upload. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready and appropriate for the distribution.

[1] Using pbuilder and sbuild.

[2] lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different, so be thorough.

[3] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

[4] https://www.debian.org/doc/debian-policy/

Regards

Phil

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to