Control: tags -1 + moreinfo Hi Yangfl,
Preamble... Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Issue I: sqlitestudio: spelling-error-in-binary "GNU Library Public License" "GNU Library General Public License" [usr/lib/x86_64-linux-gnu/libcoreSQLiteStudio.so.1.0.0] I: sqlitestudio: spelling-error-in-binary "allows to" "allows one to" [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary bahavior behavior [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary commited committed [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary completly completely [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary faild failed [usr/lib/x86_64-linux- gnu/libcoreSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary occured occurred [usr/lib/x86_64-linux- gnu/libcoreSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary occured occurred [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary overriden overridden [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary problably probably [usr/lib/x86_64-linux- gnu/libguiSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary quering querying [usr/lib/x86_64-linux- gnu/libcoreSQLiteStudio.so.1.0.0] N: I: sqlitestudio: spelling-error-in-binary writting writing [usr/lib/x86_64-linux- gnu/libcoreSQLiteStudio.so.1.0.0] N: I: sqlitestudio-plugins: spelling-error-in-binary "GNU Public Licence" "GNU General Public License" [usr/lib/x86_64-linux-gnu/sqlitestudio/libDbSqliteCipher.so] N: I: sqlitestudio-plugins: spelling-error-in-binary aheared adhered [usr/lib/x86_64-linux- gnu/sqlitestudio/libDbSqliteCipher.so] N: I: sqlitestudio-plugins: spelling-error-in-binary attemt attempt [usr/lib/x86_64-linux- gnu/sqlitestudio/libDbSqliteCipher.so] N: I: sqlitestudio-plugins: spelling-error-in-binary embeded embedded [usr/lib/x86_64-linux- gnu/sqlitestudio/libDbAndroid.so] N: I: sqlitestudio-plugins: spelling-error-in-binary proccess process [usr/lib/x86_64-linux- gnu/sqlitestudio/libScriptingTcl.so] N: I: sqlitestudio-plugins: spelling-error-in-binary rouines routines [usr/lib/x86_64-linux- gnu/sqlitestudio/libDbSqliteCipher.so] N: I: sqlitestudio-plugins: spelling-error-in-binary writting writing [usr/lib/x86_64-linux- gnu/sqlitestudio/libMultiEditorImage.so] 3. Licenses: Issue philwyett@ks-windu:~/Development/builder/debian/mentoring/sqlitestudio-3.4.4$ lrc en: Versions: recon 1.11 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-3 with OpenSSL exception| OpenSSL Plugins/DbSqliteCipher/openssl_lic.txt Expat | BSD-3-clause SQLiteStudio3/coreSQLiteStudio/chillout/windows/StackWalker.h Apache-2 | Apache-2.0 SQLiteStudio3/coreSQLiteStudio/diff/diff_match_patch.cpp Apache-2 | Apache-2.0 SQLiteStudio3/coreSQLiteStudio/diff/diff_match_patch.h GPL-3 with OpenSSL exception| Apache- 2.0 SQLiteStudio3/coreSQLiteStudio/licenses/diff_match.txt GPL-3 with OpenSSL exception| GPL-3 SQLiteStudio3/coreSQLiteStudio/licenses/gpl.txt GPL-3 with OpenSSL exception| Unicode-DFS-2016 SQLiteStudio3/coreSQLiteStudio/licenses/icu.txt GPL-3 with OpenSSL exception| LGPL-2.1 SQLiteStudio3/coreSQLiteStudio/licenses/lgpl.txt GPL-3 with OpenSSL exception| Expat SQLiteStudio3/coreSQLiteStudio/licenses/mit.txt GPL-3 with OpenSSL exception| GPL- 3+ SQLiteStudio3/coreSQLiteStudio/licenses/sqlitestudio_license.txt GPL-3 with OpenSSL exception| LGPL SQLiteStudio3/Tests/TestUtils/hippomocks.h Link to preserve formatting: https://paste.debian.net/1322257/ 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Fail dpkg-source -b . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: building sqlitestudio using existing ./sqlitestudio_3.4.4.orig.tar.gz dpkg-source: info: using patch list from debian/patches/series dpkg-source: info: local changes detected, the modified files are: sqlitestudio-3.4.4/Plugins/ConfigMigration/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/CsvExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/CsvImport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/DbAndroid/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/DbSqliteCipher/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/DbSqliteWx/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/HtmlExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/JsonExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/MultiEditorImage/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/PdfExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/Printing/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/RegExpImport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/ScriptingPython/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/ScriptingTcl/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/SqlEnterpriseFormatter/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/SqlExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/SqlFormatterSimple/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/Plugins/XmlExport/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/SQLiteStudio3/coreSQLiteStudio/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/SQLiteStudio3/guiSQLiteStudio/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/SQLiteStudio3/sqlitestudio/qmake_qmake_qm_files.qrc sqlitestudio-3.4.4/SQLiteStudio3/sqlitestudiocli/qmake_qmake_qm_files.qrc dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree dpkg-source: info: you can integrate the local changes with dpkg-source --commit dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/sqlitestudio_3.4.4- 1.diff.Sc2F1R dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build/513604 and its subdirectories 5. Reproducible builds (reporotest)[1]: Not performed due to (4. Build twice). 6. Install (No previous installs): Not performed due to (4. Build twice). 7. Upgrade (Over previous installs if any): Not performed due to (4. Build twice). Summary... I believe sqlitestudio is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
