Hi, Le 01/07/2024 à 02:36, Phil Wyett a écrit :
Hi Jörg,Preamble... Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Issue I: simple-scan: arch-dep-package-has-big-usr-share 4772kB 90% N: N: The package has a significant amount of architecture-independent data N: (over 4MB, or over 2MB and more than 50% of the package) in /usr/share but N: is an architecture-dependent package. This is wasteful of mirror space and N: bandwidth since it means distributing multiple copies of this data, one N: for each architecture. N: N: If the data in /usr/share is not architecture-independent, this is a N: Policy violation that should be fixed by moving the data elsewhere N: (usually /usr/lib). N: N: Please refer to Section 6.7.5 of the Debian Developer's Reference for N: details. N: N: Visibility: info N: Show-Always: no N: Check: huge-usr-share Something to possibly investigate at a later date for action/upload. 3. Licenses: Good 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): Good Summary... I believe simple-scan is ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
And also thanks for the work on simple-scan. In addition to the review made by Phil, I have some points: - the changelog should mention this upload closes Bug #1064939 - quite some copyright holders are missing in d/copyright - while you are at it, raise the Standards version to latest one- although not mandatory for my sponsorship, it would be great if the package was hosted in Salsa (the repo exists! The last commit there was 5 years ago, pointing Vcs-* fields to this repo).
Regards Phil
Thanks again, -- Pierre
OpenPGP_signature.asc
Description: OpenPGP digital signature
