Hi Jörg, Preamble...
Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Good Note: There are a number of spelling errors that need to be reported upstream and hopefully corrected for a future release. 3. Licenses: Issues philwyett@ks-windu:~/Development/builder/debian/mentoring/shotwell-0.32.6$ lrc en: Versions: recon 1.11 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck LGPL-2.1 | LGPL-2.1+ plugins/authenticator/shotwell/FlickrPublishingAuthenticator.vala LGPL-2.1 | LGPL-2.1+ plugins/authenticator/shotwell/OAuth1Authenticator.vala LGPL-2.1 | LGPL-2.1+ plugins/authenticator/shotwell/TumblrAuthenticator.vala LGPL-2.1 | LGPL-2.1+ plugins/common/BuilderPane.vala LGPL-2.1 | LGPL-2.1+ plugins/common/OAuth1Support.vala LGPL-2.1 | LGPL-2.1+ plugins/common/Resources.vala LGPL-2.1 | LGPL-2.1+ plugins/common/RESTSupport.vala LGPL-2.1 | LGPL-2.1+ plugins/common/WebAuthenticationPane.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/FlickrPublishing.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/PhotosPublisher.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/PhotosPublishingPane.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/PhotosService.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/PhotosUploader.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/shotwell-publishing.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/TumblrPublishing.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-publishing/YouTubePublishing.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/BlindsEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/ChessEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/CircleEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/CirclesEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/ClockEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/CrumbleEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/FadeEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/shotwell-transitions.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/SlideEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/SquaresEffect.vala LGPL-2.1 | LGPL-2.1+ plugins/shotwell-transitions/StripesEffect.vala LGPL-2.1 | LGPL-2.1+ settings-migrator/shotwell-settings-migrator LGPL-2.1 | LGPL-2.1+ src/AppDirs.vala LGPL-2.1 | LGPL-2.1+ src/Application.vala LGPL-2.1 | LGPL-2.1+ src/AppWindow.vala LGPL-2.1 | LGPL-2.1+ src/BatchImport.vala LGPL-2.1 | LGPL-2.1+ src/Box.vala LGPL-2.1 | LGPL-2.1+ src/camera/CameraBranch.vala LGPL-2.1 | LGPL-2.1+ src/camera/CameraTable.vala LGPL-2.1 | LGPL-2.1+ src/camera/Camera.vala LGPL-2.1 | LGPL-2.1+ src/camera/DiscoveredCamera.vala LGPL-2.1 | LGPL-2.1+ src/camera/GPhoto.vala LGPL-2.1 | LGPL-2.1+ src/camera/ImportPage.vala LGPL-2.1 | LGPL-2.1+ src/CheckerboardItemText.vala LGPL-2.1 | LGPL-2.1+ src/CheckerboardItem.vala LGPL-2.1 | LGPL-2.1+ src/CheckerboardLayout.vala LGPL-2.1 | LGPL-2.1+ src/CheckerboardPage.vala LGPL-2.1 | LGPL-2.1+ src/CollectionPage.vala LGPL-2.1 | LGPL-2.1+ src/ColorTransformation.vala LGPL-2.1 | LGPL-2.1+ src/CommandManager.vala LGPL-2.1 | LGPL-2.1+ src/Commands.vala LGPL-2.1 | LGPL-2.1+ src/config/ConfigurationInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/config/Config.vala LGPL-2.1 | LGPL-2.1+ src/config/GSettingsEngine.vala LGPL-2.1 | LGPL-2.1+ src/core/Alteration.vala LGPL-2.1 | LGPL-2.1+ src/core/ContainerSourceCollection.vala LGPL-2.1 | LGPL-2.1+ src/core/Core.vala LGPL-2.1 | LGPL-2.1+ src/core/DatabaseSourceCollection.vala LGPL-2.1 | LGPL-2.1+ src/core/DataCollection.vala LGPL-2.1 | LGPL-2.1+ src/core/DataObject.vala LGPL-2.1 | LGPL-2.1+ src/core/DataSet.vala LGPL-2.1 | LGPL-2.1+ src/core/DataSourceTypes.vala LGPL-2.1 | LGPL-2.1+ src/core/DataSource.vala LGPL-2.1 | LGPL-2.1+ src/core/DataViewTypes.vala LGPL-2.1 | LGPL-2.1+ src/core/DataView.vala LGPL-2.1 | LGPL-2.1+ src/core/SourceCollection.vala LGPL-2.1 | LGPL-2.1+ src/core/SourceHoldingTank.vala LGPL-2.1 | LGPL-2.1+ src/core/SourceInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/core/Tracker.vala LGPL-2.1 | LGPL-2.1+ src/core/util.vala LGPL-2.1 | LGPL-2.1+ src/core/ViewCollection.vala LGPL-2.1 | LGPL-2.1+ src/data_imports/DataImportJob.vala LGPL-2.1 | LGPL-2.1+ src/data_imports/DataImportSource.vala LGPL-2.1 | LGPL-2.1+ src/data_imports/DataImportsPluginHost.vala LGPL-2.1 | LGPL-2.1+ src/data_imports/DataImportsUI.vala LGPL-2.1 | LGPL-2.1+ src/data_imports/DataImports.vala LGPL-2.1 | LGPL-2.1+ src/db/DatabaseTable.vala LGPL-2.1 | LGPL-2.1+ src/db/Db.vala LGPL-2.1 | LGPL-2.1+ src/db/EventTable.vala LGPL-2.1 | LGPL-2.1+ src/db/FaceLocationTable.vala LGPL-2.1 | LGPL-2.1+ src/db/FaceTable.vala LGPL-2.1 | LGPL-2.1+ src/db/PhotoTable.vala LGPL-2.1 | LGPL-2.1+ src/db/SavedSearchDBTable.vala LGPL-2.1 | LGPL-2.1+ src/db/TagTable.vala LGPL-2.1 | LGPL-2.1+ src/db/TombstoneTable.vala LGPL-2.1 | LGPL-2.1+ src/db/VersionTable.vala LGPL-2.1 | LGPL-2.1+ src/db/VideoTable.vala LGPL-2.1 | LGPL-2.1+ src/Debug.vala LGPL-2.1 | LGPL-2.1+ src/DesktopIntegration.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/AdjustDateTimeDialog.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/EntryMultiCompletion.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/ExportDialog.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/MultiTextEntryDialog.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/Preferences.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/ProgressDialog.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/SetBackgroundSlideshow.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/SetBackground.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/TextEntry.vala LGPL-2.1 | LGPL-2.1+ src/Dialogs.vala LGPL-2.1 | LGPL-2.1+ src/dialogs/WelcomeDialog.vala LGPL-2.1 | LGPL-2.1+ src/Dimensions.vala LGPL-2.1 | LGPL-2.1+ src/direct/DirectPhotoPage.vala LGPL-2.1 | LGPL-2.1+ src/direct/DirectPhoto.vala LGPL-2.1 | LGPL-2.1+ src/direct/Direct.vala LGPL-2.1 | LGPL-2.1+ src/direct/DirectView.vala LGPL-2.1 | LGPL-2.1+ src/direct/DirectWindow.vala LGPL-2.1 | LGPL-2.1+ src/DirectoryMonitor.vala LGPL-2.1 | LGPL-2.1+ src/DragAndDropHandler.vala LGPL-2.1 | LGPL-2.1+ src/editing_tools/EditingTools.vala LGPL-2.1 | LGPL-2.1+ src/editing_tools/RGBHistogramManipulator.vala LGPL-2.1 | LGPL-2.1+ src/editing_tools/StraightenTool.vala LGPL-2.1 | LGPL-2.1+ src/events/EventDirectoryItem.vala LGPL-2.1 | LGPL-2.1+ src/events/EventPage.vala LGPL-2.1 | LGPL-2.1+ src/events/EventsBranch.vala LGPL-2.1 | LGPL-2.1+ src/events/EventsDirectoryPage.vala LGPL-2.1 | LGPL-2.1+ src/events/Events.vala LGPL-2.1 | LGPL-2.1+ src/Event.vala LGPL-2.1 | LGPL-2.1+ src/Exporter.vala LGPL-2.1 | Expat src/faces/FaceDetect.vala LGPL-2.1 | LGPL-2.1+ src/faces/FaceLocation.vala LGPL-2.1 | LGPL-2.1+ src/faces/FacePage.vala LGPL-2.1 | LGPL-2.1+ src/faces/FacesBranch.vala LGPL-2.1 | LGPL-2.1+ src/faces/FaceShape.vala LGPL-2.1 | LGPL-2.1+ src/faces/FacesTool.vala LGPL-2.1 | LGPL-2.1+ src/faces/Faces.vala LGPL-2.1 | LGPL-2.1+ src/faces/Face.vala LGPL-2.1 | LGPL-2.1+ src/folders/FoldersBranch.vala LGPL-2.1 | LGPL-2.1+ src/folders/FoldersPage.vala LGPL-2.1 | LGPL-2.1+ src/folders/Folders.vala LGPL-2.1 | LGPL-2.1+ src/import-roll/ImportRollEntry.vala LGPL-2.1 | LGPL-2.1+ src/International.vala LGPL-2.1 | LGPL-2.1+ src/library/BackgroundProgressBar.vala LGPL-2.1 | LGPL-2.1+ src/LibraryFiles.vala LGPL-2.1 | LGPL-2.1+ src/library/FlaggedPage.vala LGPL-2.1 | LGPL-2.1+ src/library/FlaggedSidebarEntry.vala LGPL-2.1 | LGPL-2.1+ src/library/ImportQueuePage.vala LGPL-2.1 | LGPL-2.1+ src/library/ImportQueueSidebarEntry.vala LGPL-2.1 | LGPL-2.1+ src/library/LastImportPage.vala LGPL-2.1 | LGPL-2.1+ src/library/LastImportSidebarEntry.vala LGPL-2.1 | LGPL-2.1+ src/library/LibraryBranch.vala LGPL-2.1 | LGPL-2.1+ src/library/Library.vala LGPL-2.1 | LGPL-2.1+ src/library/LibraryWindow.vala LGPL-2.1 | LGPL-2.1+ src/LibraryMonitor.vala LGPL-2.1 | LGPL-2.1+ src/library/OfflinePage.vala LGPL-2.1 | LGPL-2.1+ src/library/OfflineSidebarEntry.vala LGPL-2.1 | LGPL-2.1+ src/library/TrashPage.vala LGPL-2.1 | LGPL-2.1+ src/library/TrashSidebarEntry.vala LGPL-2.1 | LGPL-2.1+ src/main.vala LGPL-2.1 | LGPL-2.1+ src/MapWidget.vala LGPL-2.1 | LGPL-2.1+ src/MediaDataRepresentation.vala LGPL-2.1 | LGPL-2.1+ src/MediaInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/MediaMonitor.vala LGPL-2.1 | LGPL-2.1+ src/MediaPage.vala LGPL-2.1 | LGPL-2.1+ src/MediaViewTracker.vala LGPL-2.1 | LGPL-2.1+ src/metadata/MediaMetadata.vala LGPL-2.1 | LGPL-2.1+ src/MetadataWriter.vala LGPL-2.1 | LGPL-2.1+ src/Orientation.vala LGPL-2.1 | LGPL-2.1+ src/PageMessagePane.vala LGPL-2.1 | LGPL-2.1+ src/Page.vala LGPL-2.1 | LGPL-2.1+ src/PhotoMonitor.vala LGPL-2.1 | LGPL-2.1+ src/PhotoPage.vala LGPL-2.1 | LGPL-2.1+ src/photos/AvifSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/BmpSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/GdkSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/GifSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/GRaw.vala LGPL-2.1 | LGPL-2.1+ src/photos/HeifSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/JfifSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/JpegXLSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/PhotoFileAdapter.vala LGPL-2.1 | LGPL-2.1+ src/photos/PhotoFileFormat.vala LGPL-2.1 | LGPL-2.1+ src/photos/PhotoFileSniffer.vala LGPL-2.1 | LGPL-2.1+ src/photos/PhotoMetadata.vala LGPL-2.1 | LGPL-2.1+ src/photos/Photos.vala LGPL-2.1 | LGPL-2.1+ src/photos/PngSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/RawSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/TiffSupport.vala LGPL-2.1 | LGPL-2.1+ src/photos/WebPSupport.vala LGPL-2.1 | LGPL-2.1+ src/Photo.vala LGPL-2.1 | LGPL-2.1+ src/PixbufCache.vala LGPL-2.1 | LGPL-2.1+ src/plugins/DataImportsInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/plugins/ManifestWidget.vala LGPL-2.1 | LGPL-2.1+ src/plugins/Plugins.vala LGPL-2.1 | LGPL-2.1+ src/plugins/PublishingInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/plugins/SpitInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/plugins/StandardHostInterface.vala LGPL-2.1 | LGPL-2.1+ src/plugins/TransitionsInterfaces.vala LGPL-2.1 | LGPL-2.1+ src/Printing.vala LGPL-2.1 | LGPL-2.1+ src/Profiles.vala LGPL-2.1 | LGPL-2.1+ src/Properties.vala LGPL-2.1 | LGPL-2.1+ src/publishing/APIGlue.vala LGPL-2.1 | LGPL-2.1+ src/publishing/LoginWelcomePaneWidget.vala LGPL-2.1 | LGPL-2.1+ src/publishing/ProgressPaneWidget.vala LGPL-2.1 | LGPL-2.1+ src/publishing/PublishingPluginHost.vala LGPL-2.1 | LGPL-2.1+ src/publishing/PublishingUI.vala LGPL-2.1 | LGPL-2.1+ src/publishing/Publishing.vala LGPL-2.1 | LGPL-2.1+ src/publishing/StaticMessagePaneWidget.vala LGPL-2.1 | LGPL-2.1+ src/publishing/SuccessPaneWidget.vala LGPL-2.1 | LGPL-2.1+ src/Resources.vala LGPL-2.1 | LGPL-2.1+ src/Screensaver.vala LGPL-2.1 | LGPL-2.1+ src/searches/SavedSearchDialog.vala LGPL-2.1 | LGPL-2.1+ src/searches/SavedSearchPage.vala LGPL-2.1 | LGPL-2.1+ src/searches/SearchBoolean.vala LGPL-2.1 | LGPL-2.1+ src/searches/SearchesBranch.vala LGPL-2.1 | LGPL-2.1+ src/searches/Searches.vala LGPL-2.1 | LGPL-2.1+ src/SearchFilter.vala LGPL-2.1 | LGPL-2.1+ src/sidebar/Branch.vala LGPL-2.1 | LGPL-2.1+ src/sidebar/common.vala LGPL-2.1 | LGPL-2.1+ src/sidebar/Entry.vala LGPL-2.1 | LGPL-2.1+ src/sidebar/Sidebar.vala LGPL-2.1 | LGPL-2.1+ src/sidebar/Tree.vala LGPL-2.1 | LGPL-2.1+ src/SinglePhotoPage.vala LGPL-2.1 | LGPL-2.1+ src/SlideshowPage.vala LGPL-2.1 | LGPL-2.1+ src/slideshow/Slideshow.vala LGPL-2.1 | LGPL-2.1+ src/slideshow/TransitionEffects.vala LGPL-2.1 | LGPL-2.1+ src/SortedList.vala LGPL-2.1 | LGPL-2.1+ src/tags/HierarchicalTagIndex.vala LGPL-2.1 | LGPL-2.1+ src/tags/HierarchicalTagUtilities.vala LGPL-2.1 | LGPL-2.1+ src/tags/TagPage.vala LGPL-2.1 | LGPL-2.1+ src/tags/TagsBranch.vala LGPL-2.1 | LGPL-2.1+ src/tags/Tags.vala LGPL-2.1 | LGPL-2.1+ src/Tag.vala LGPL-2.1 | LGPL-2.1+ src/threads/BackgroundJob.vala LGPL-2.1 | LGPL-2.1+ src/threads/Semaphore.vala LGPL-2.1 | LGPL-2.1+ src/threads/Threads.vala LGPL-2.1 | LGPL-2.1+ src/threads/Workers.vala LGPL-2.1 | LGPL-2.1+ src/ThumbnailCache.vala LGPL-2.1 | LGPL-2.1+ src/Thumbnail.vala LGPL-2.1 | LGPL-2.1+ src/TimedQueue.vala LGPL-2.1 | LGPL-2.1+ src/Tombstone.vala LGPL-2.1 | LGPL-2.1+ src/_transformation.c LGPL-2.1 | LGPL-2.1+ src/.unitize/_CameraInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_ConfigInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_CoreInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_DataImportsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_DbInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_DirectInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_Direct_unitize_entry.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_EditingToolsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_EventsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_FoldersInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_LibraryInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_Library_unitize_entry.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_PhotosInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_PluginsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_PublishingInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_SearchesInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_SidebarInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_SlideshowInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_TagsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_ThreadsInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_UnitInternals.vala LGPL-2.1 | LGPL-2.1+ src/.unitize/_UtilInternals.vala LGPL-2.1 | LGPL-2.1+ src/unit/Unit.vala LGPL-2.1 | LGPL-2.1+ src/UnityProgressBar.vala LGPL-2.1 | LGPL-2.1+ src/Upgrades.vala LGPL-2.1 | LGPL-2.1+ src/util/file.vala LGPL-2.1 | LGPL-2.1+ src/util/image.vala LGPL-2.1 | LGPL-2.1+ src/util/KeyValueMap.vala LGPL-2.1 | LGPL-2.1+ src/util/misc.vala LGPL-2.1 | LGPL-2.1+ src/util/string.vala LGPL-2.1 | LGPL-2.1+ src/util/system.vala LGPL-2.1 | LGPL-2.1+ src/util/ui.vala LGPL-2.1 | LGPL-2.1+ src/util/Util.vala LGPL-2.1 | LGPL-2.1+ src/VideoMonitor.vala LGPL-2.1 | LGPL-2.1+ src/video-support/VideoImportParams.vala LGPL-2.1 | LGPL-2.1+ src/video-support/VideoMetadata.vala LGPL-2.1 | LGPL-2.1+ src/video-support/VideoReader.vala LGPL-2.1 | LGPL-2.1+ src/video-support/VideoSourceCollection.vala LGPL-2.1 | LGPL-2.1+ src/video-support/Video.vala LGPL-2.1 | LGPL-2.1+ subprojects/shotwell-facedetect/shotwell-facedetect.cpp LGPL-2.1 | LGPL-2.1+ subprojects/shotwell-facedetect/shotwell-facedetect.hpp LGPL-2.1 | Expat test/server.py LGPL-2.1 | LGPL-2.1+ thumbnailer/shotwell-video-thumbnailer.vala LGPL-2.1 | LGPL-2.1+ vapi/libexif.vapi LGPL-2.1 | LGPL-2.1+ vapi/libgphoto2.vapi LGPL-2.1 | LGPL-2.1+ vapi/libraw.vapi LGPL-2.1 | LGPL-2.1+ vapi/shotwell-gphoto-helper.h I think these can be looked at and easily corrected for this or a future upload. 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): Good Summary... I believe shotwell is now ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
