On Fri, 2024-06-28 at 12:25 +0100, Phil Wyett wrote: > Hi Kai-Chuan, > > Preamble... > > Thanks for taking time to create this package and your contribution to Debian. > > The below review is for assistance. It is offered to help submitters of > packages to Debian mentors improve their packages prior to possible > sponsorship into Debian. There is no obligation on behalf of the subitter to > make any alterations based upon information provided in the review. > > Review... > > 1. Build: Good > > 2. Lintian: Warnings / Information > > W: fibocom-ma-service-dbgsym: debug-file-with-no-debug-symbols > [usr/lib/debug/.build-id/31/c688714629cba39332ccc6c74073bf344b389e.debug] > N: > N: The binary is installed as a detached "debug symbols" ELF file, but it > N: does not appear to have debug information associated with it. > N: > N: A common cause is not passing -g to GCC when compiling. > N: > N: Implementation detail: Lintian checks for the ".debug_line" and the > N: ".debug_str" sections. If either of these are present, the binary is > N: assumed to contain debug information. > N: > N: Please refer to Bug#668437 for details. > N: > N: Visibility: warning > N: Show-Always: no > N: Check: binaries/debug-symbols/detached > > Note: > > Something to be looked at. > > I: fibocom-pc-services source: missing-explanation-for-contrib-or-non-free- > package [debian/copyright:1] > N: > N: The specified package is in the contrib or non-free archive area but does > N: not include a "Comment" (or "Disclaimer") field in its copyright file. > N: > N: Please add a brief comment why this package cannot be part of the main > N: Debian distribution. > N: > N: Please refer to Copyright information (Section 12.5) in the Debian Policy > N: Manual for details. > N: > N: Visibility: info > N: Show-Always: no > N: Check: debian/copyright/dep5 > > Note: > > Something to be looked at. > > 3. Licenses: Issues > > philwyett@ks-windu:~/Development/builder/debian/mentoring/fibocom-pc-services- > 1.0.10$ lrc > en: Versions: recon 1.11 check 3.3.9-1 > > Parsing Source Tree .... > Reading copyright .... > Running licensecheck .... > > d/copyright | licensecheck > > GPL-2+ | > Zlib application/3rd/iniparser/test/CuTest_license.txt > GPL-2+ | BSD-3-clause application/3rd/qdl/firehose.c > GPL-2+ | BSD-3-clause application/3rd/qdl/patch.c > GPL-2+ | BSD-3-clause application/3rd/qdl/program.c > GPL-2+ | BSD-3-clause application/3rd/qdl/qdl.c > GPL-2+ | BSD-3-clause application/3rd/qdl/sahara.c > GPL-2+ | BSD-3-clause application/3rd/qdl/ufs.c > GPL-2+ | BSD-3-clause application/3rd/qdl/ufs.h > GPL-2+ | BSD-3-clause application/3rd/qdl/util.c > GPL-2+ | Expat > application/3rd/safestringlib/CMakeLists.txt > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_lib_errno.h > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_lib_errno.h.in > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_lib.h > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_mem_lib.h > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_str_lib.h > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_types.h > GPL-2+ | > Expat application/3rd/safestringlib/include/safe_types.h.in > GPL-2+ | > Expat application/3rd/safestringlib/include/snprintf_s.h > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/abort_handler_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/ignore_handler_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcmp16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcmp32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcpy16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcpy32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memmove16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memmove32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memmove_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/mem_primitives_lib.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/mem_primitives_lib.h > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memset16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memset32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memset_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memzero16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memzero32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/memzero_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/safeclib_private.h > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/safe_mem_constraint.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/safe_mem_constraint.h > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/safe_str_constraint.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/safe_str_constraint.h > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/snprintf_support.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/stpcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/stpncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcasecmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcasestr_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcmpfld_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcpyfldin_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcpyfldout_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcpyfld_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strcspn_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strfirstchar_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strfirstdiff_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strfirstsame_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strisalphanumeric_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strisascii_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strisdigit_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strishex_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strislowercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strismixedcase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strispassword_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strisuppercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strlastchar_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strlastdiff_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strlastsame_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strljustify_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strncat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strnlen_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strnterminate_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strpbrk_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strprefix_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strremovews_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strspn_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strstr_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strtok_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strtolowercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strtouppercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/strzero_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcpcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcscat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcscpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcsncat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcsncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wcsnlen_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wmemcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wmemcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wmemmove_s.c > GPL-2+ | > Expat application/3rd/safestringlib/safeclib/wmemset_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/CMakeLists.txt > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/Safe_String_UnitTestMai > n.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcmp16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcmp32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcpy16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcpy32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memmove16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memmove32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memmove_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memset16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memset32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memset_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memzero16_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memzero32_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_memzero_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_private.h > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_stpcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_stpncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcasecmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcasestr_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcmpfld_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcpyfldin_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcpyfldout_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcpyfld_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strcspn_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strfirstchar_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strfirstdiff_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strfirstsame_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strisalphanumeric_ > s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strisascii_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strisdigit_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strishex_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strislowercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strismixed_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strispassword_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strisuppercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strlastchar_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strlastdiff_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strlastsame_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strljustify_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strncat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strnlen_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strnterminate_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strpbrk_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strprefix_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strremovews_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strspn_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strstr_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strtok_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strtolowercase_s.c > GPL-2+ | > Expat > application/3rd/safestringlib/unittests/test_strtouppercase_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_strzero_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcpcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcscat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcscpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcsncat_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcsncpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wcsnlen_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wmemcmp_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wmemcpy_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wmemmove_s.c > GPL-2+ | > Expat application/3rd/safestringlib/unittests/test_wmemset_s.c > GPL-2+ | Expat application/3rd/safestringlib/version.cmake > GPL-2+ | GPL- > 2 application/fibo_config_service/include/fibo_config_helper.h > GPL-2+ | GPL- > 2 application/fibo_config_service/include/fibo_config_parse.h > GPL-2+ | GPL- > 2 application/fibo_config_service/include/fibo_dynamic_config.h > GPL-2+ | GPL- > 2 application/fibo_config_service/include/fibo_parse_xml.h > GPL-2+ | GPL- > 2 application/fibo_config_service/include/fibo_static_config.h > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_config_helper.c > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_config_main.c > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_config_parse.c > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_dynamic_config.c > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_static_config.c > GPL-2+ | GPL- > 2 application/fibo_config_service/src/fibo_xml_parse.c > GPL-2+ | GPL- > 2 application/fibo_flash_service/fibo_flash_main.c > GPL-2+ | GPL- > 2 application/fibo_flash_service/fibo_flash_main.h > GPL-2+ | GPL- > 2 application/fibo_flash_service/fibo_flash_parse_xml.c > GPL-2+ | GPL- > 2 application/fibo_helper_service/at_channel/common.cc > GPL-2+ | GPL- > 2 application/fibo_helper_service/at_channel/common.h > GPL-2+ | GPL- > 2 application/fibo_helper_service/at_channel/serial_port.cc > GPL-2+ | GPL- > 2 application/fibo_helper_service/at_channel/serial_port.h > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_adapter.c > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_adapter.h > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_basic_func.c > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_basic_func.h > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_common.h > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_log.c > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_main.c > GPL-2+ | GPL- > 2 application/fibo_helper_service/fibo_helper_mbim_main.c > GPL-2+ | GPL-2 > application/include/common/fibo_helper_cid.h > GPL-2+ | GPL-2 application/include/common/fibo_log.h > GPL-2+ | GPL-2 > application/include/common/fibo_private_log.h > GPL-2+ | CC0-1.0 install > > URL, formatted pastebin: https://paste.debian.net/1321746/ > > Note: > > I had a look at a few of the files and they were not licensed correctly in > 'debian/copyright'. I would suggest an audit of the files and > 'debian/copyright' > to remedy any issues. > > 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good > > 5. Install (No previous installs): Not performed at this time > > 6. Upgrade (Over previous installs if any): N/A > > Regards > > Phil >
Hi Kai-Chuan, Forgot to add this one to previous email. The 'debian/watch' file is not complete. The upstream is github and does releases. The 'debian/watch' should be created to monitor for new upstream releases. Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
