Control: tags -1 + moreinfo Hi Alan,
Thanks for making another update of the package. Your effort and contribution to Debian is very much welcomed. Review... 1. Build: OK 2. Lintian: ISSUES - See Additional: C I: hyprland: hardening-no-fortify-functions [usr/bin/hyprctl] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: hyprland: hardening-no-fortify-functions [usr/bin/hyprpm] N: I: hyprland: spelling-error-in-binary availablity availability [usr/bin/hyprpm] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: hyprland: spelling-error-in-binary becuase because [usr/bin/Hyprland] N: I: hyprland: spelling-error-in-binary doesnt doesn't [usr/bin/Hyprland] N: I: hyprland: spelling-error-in-binary dont don't [usr/bin/Hyprland] N: I: hyprland: spelling-error-in-binary enountered encountered [usr/bin/Hyprland] N: I: hyprland: spelling-error-in-binary overriden overridden [usr/bin/Hyprland] E: Lintian run failed (runtime error) 3. Licenses check: ISSUES philwyett@ks-windu:~/Development/builder/debian/mentoring/hyprland-0.41.1+ds$ lrc en: Versions: recon 1.10.1 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck BSD-3-Clause | LGPL-2.1 protocols/kde-server-decoration.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wayland- drm.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wlr-data- control-unstable-v1.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wlr-foreign- toplevel-management-unstable-v1.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wlr-gamma- control-unstable-v1.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wlr-layer- shell-unstable-v1.xml BSD-3-Clause | HPND-sell-variant and/or NTP~disclaimer protocols/wlr-output- management-unstable-v1.xml MIT | Expat subprojects/wlroots-hyprland/meson.build MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/drm.xml MIT | LGPL-2.1+ subprojects/wlroots-hyprland/protocol/server- decoration.xml MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/wlr-data-control-unstable-v1.xml MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/wlr-foreign-toplevel-management-unstable-v1.xml MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/wlr-gamma-control-unstable-v1.xml MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/wlr-layer-shell-unstable-v1.xml MIT | HPND-sell-variant and/or NTP~disclaimer subprojects/wlroots- hyprland/protocol/wlr-output-management-unstable-v1.xml See link below for pastebin of above text that keeps formatting. https://paste.debian.net/1320794/ 4. Build Twice (sudo pbuilder build --twice <package>.dsc): OK 5. Install (No previous installs): OK 6. Upgrade (Over previous installs if any): N/A Additional... A. Build time issue dpkg-gencontrol: warning: Depends field of package hyprland-backgrounds: substitution variable ${shlibs:Depends} used, but is not defined dpkg-gencontrol: warning: Depends field of package hyprland-dev: substitution variable ${shlibs:Depends} used, but is not defined Remove '${shlibs:Depends}' from each of the above packages and the build time warnings will be eliminated. B. Hint The below line can be seen in this packages build log. dwz: debian/hyprland/usr/bin/Hyprland: DWARF compression not beneficial - old size 238847458 new size 240478324 If you wish. To disable this none beneficial compression of the binary, add the below snippet to your 'debian/rules' file. override_dh_dwz: : Skipping dwz, compression not beneficial on filezilla binary C. The noted lintian issues I am confident you will investigate and take action where necessary. Summary... Please consider addressing the issues raised where applicable and remove the 'moreinfo' tag when doing next/fixed upload. Regards Phil -- Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
