Xiyue Deng <manp...@gmail.com> writes:

You're incorrect about:

>    * Drop unused override_dh_auto_test in d/rules (dh_elpa_test is in
>      effect)

  override_dh_auto_test:
    @echo Using dh_elpa_test to run tests instead of upstream Makefile

Used to be useful, because the Makefile tests used to run as well as the
dh_elpa_test ones.  Dh_elpa_test was also "in effect then"...

>    * Update debian copyright year in d/copyright

-Copyright: 2015-2017 David Bremner <brem...@debian.org>
+Copyright: 2015-2024 David Bremner <brem...@debian.org>

In terms of copyright, please explain your understanding of copyright
what you're doing here.  This is not a mere 's/17/24/' symbol
manipulation.

> Note: this revision drops the dependency on markdown, which is important
> so that itself and all its reverse dependencies are free from
> bug#1063645 so that they are free from being removed from testing.

This is premature.  Also, does upstream skip functional tests if a
$PATH/markdown binary cannot be called?  If this is the case then the
correct action is to configure a $PATH/compatible-markdown-replacement.

Attachment: signature.asc
Description: PGP signature

Reply via email to