(forgotten cc) Am Freitag, dem 03.05.2024 um 18:50 +0200 schrieb Tobias Frost: > reviewing your new package: > > - d/changelog > - generally documents only changes to the packaging, not "upstream" changes > (the entry "Fixed logrotate conf user name" is an upstream change.) > There are exceptions, like if it a very noteworthy change, but this > is one isn't in that category. > - When packaging a new upstream version, you say so in the changelog. > (Like first changelog entry: > * New upstream version. > ) > - There are undocumented changes, for example the change to the > Standard-Version. >
Done. > A nitpick on d/rules: > I'm a fan of declarative syntax, so I'd replace the dh_clean override > with specifing the file to be deleted in the file d/clean. (If you feel > different about this, it is ok to ignore my nitpicking) Done, thx. > Remarks on Readme.md: > - It cointains only information not relevant when the user is > installing the binary package (like how to build, how to install and > where to find the packages), so it should not be installed into > the binary package. Not exactly. There is the important line "Our packages are built with MQTT support, but without OMS support.". In addition it is a moving target. So I'd prefer to keep it as now. > - "Debian" is written with a captial "D". Done. > - The sentence "Unfortunately Debian armhf packages do not > run on Raspberry Pi 1 although the architecture on the RPi is named armhf. > Using Raspian armhf packages fixes that." is a bit hard to parse, a > bit off: > - Raspberry Pi 1 is supported by the Debian armel architecture, so people > running (real) Debian on the Pi 1 need to use "armel" not "armhf". > - Paspian has been renamed to Raspberry Pi OS, so the naming should > maybe be also updated. Done. During the discussion more changes were added. > Maybe this should be separated into a Debian and Raspberry Pi OS > section? (They are different distributions anyways…) The handling is very similar from the users perspective. > > Some parts already mentioned for the previous upload, would be great if > you could start tackling them: > > As you are involved with upstream: > The manpage, initfile, systemd service file should probably be included in the > upstream part, it is not only useful for Debian alone. > It is currently under discussion if other installation methods are still needed. > Linitian: (I've pre-filtered them a bit already on those that should be > investigaged. If harderning is working now, override the linitian I: tag.) > I: vzlogger source: debian-rules-parses-dpkg-parsechangelog [debian/rules:15] > I: vzlogger: hardening-no-bindnow [usr/bin/vzlogger] > I: vzlogger: systemd-service-file-missing-documentation-key [usr/lib/systemd/system/vzlogger.service] > P: vzlogger source: trailing-whitespace [debian/changelog:10] > P: vzlogger source: trailing-whitespace [debian/changelog:4] > P: vzlogger source: trailing-whitespace [debian/control:17] > P: vzlogger source: trailing-whitespace [debian/control:40] > P: vzlogger source: trailing-whitespace [debian/rules:45] > X: vzlogger: systemd-service-file-missing-hardening-features [usr/lib/systemd/system/vzlogger.service] > X: vzlogger source: upstream-metadata-file-is-missing All done except for upstream-metadata-file-is-missing. I don't think this is of much use for a service. An updated 0.8.5-1 has been uploaded. Sincerely, Joachim
