X-Debbugs-CC: kd8...@gmail.com Hi,
On Tue, 12 Sep 2023 22:54:25 -0400 Yogu NY3W <kd8...@gmail.com> wrote: > I've removed the redundant dh_auto_clean in d/rules, created > debian/a2d.install to list the extra files, and made necessary adjustments > in setup.py to manage these files. Would you kindly review and confirm if > the package now aligns with Debian's requirements? A bypasser here and took a look at your package. Some comments: * debian/a2d.conffiles is empty and obviously useless. Please drop it. * The non-atomic modification to crontab all over the place is worrying. Please avoid manual invocation of crontab whenever possible and use dh_installcron(1) whenever applicable. * "Name" field in debian/upstream/metadata is deprecated. Please check the up-to-date instruction on this file at https://wiki.debian.org/UpstreamMetadata . * I am deeply worried by your invasive manipulation of system files, especially the manipulation of files of other packages. Namely: -> Executing "rm -r" for files under /usr/lib/ (!!) -> Executing "rm -r" for files under /usr/local/ (!!!) -> Creating files under /usr/local/ in preinst script (!!!) This is a clear violation of Debian Policy. Regular package shall not touch files under /usr/local/ under any circumstances. -> Using "mkdir -p" to create directories (!) Please use debian/<package>.dirs file as used by dh_installdirs(1) for safe directory creation and deletion. -> Executing "rm" for /etc/nginx/sites-enabled/default (!!!!!) This will be catastrophic if the user had any manual modification to the default configuration file. Those with (!) marked are clear red flags and will definitely be rejected during package review. The general rule is to avoid writing anything into maintscripts (preinst, preinst, postinst, postrm) whenever possible since they are error-prone. Since your package seems to have deep integration with the system, such integration will need to be carefully designed. I encourage looking into other system packages and see how they handle /var/, crontab, etc. Thanks, Boyuan Yang
signature.asc
Description: This is a digitally signed message part
