On 2022-11-12 18:17:23, Peter Colberg wrote: > Dear Debian mentors, > > I have updated the fuzzel package to version 1.8.2-1 [1]. I will > push a signed tag once the package has been accepted into unstable.
Hi! So a quick review of the package... It looks like it ships a third-party library, nanosvg. I don't know if that's already packaged in Debian, but it might make the FTP-masters unhappy, especially since it's not mentioned in debian/copyright. So the latter should be fixed, at the very least, and we might consider packaging that library separately... ... that said, it looks like many other packages do ship a copy of that library, maybe it's the way it's designed to be shipped? https://codesearch.debian.net/search?q=nanosvg&perpkg=1 wxwidgets just vendors it, but does mention it in the debian/copyright, however: https://sources.debian.org/src/wxwidgets3.2/3.2.1%2Bdfsg-1/debian/copyright/#L28 So there's that: at least add that to the debian/copyright. Also, I've had trouble reproducing the upstream tarball. I tried to build the package with git-buildpackage: gbp buildpackage --git-debian-branch=main --git-upstream-tag=1.8.2 ... but that gives me a different tarball than upstream. git-buildpackage generates a tarball with foot-1.8.2/ as a top directory, while upstream has foot/. I'm not sure how to resolve this, but you should at least provide the upstream tarball ... somewhere so that it can be uploaded safely. You might want to configure git-buildpackage or some other git-building tool in the package as well, since it seems that (git) is what you rely on to build this. I can probably just live with the upstream tarball for now, but that might be something you want to consider documenting in debian/README.source or something. Otherwise this is almost ready to go, as far as I'm concerned, and I'll be happy to sponsor this once it has a proper debian/copyright. Try running decopy on the source to see what comes up... a. -- There is no cloud, it's just someone else's computer. - Chris Watterson
signature.asc
Description: PGP signature
