On 8/21/22 00:32, Tobias Frost wrote:
Package: sponsorship-requests
Followup-For: Bug #1017815
Hi Matthew,
thanks for the updated package fixing an RC bug!
Thanks for sponsoring!
I have is some feedback regarding it:
- The format of d/changelog is a bit unusual, usually there are no
blank lines between entries.
Ah I did not realise this was non-standard. Should I adjust the entire
d/changelog in the next release? Or should I just omit blank lines from
now on?
- d/changelog should document every change to the Debian packaging,
there are many changes that are not documented:
- update watch file
- update Standard-Version
- updates to d/control, versions of depdendencies.
I did not realise details of the packaging itself was relevant to the
changelog. Though apparently past me did, as I see entries in previous
releases about Standards-Version. In the next release, I'll try to be
more comprehensive.
- d/copyright needs updating, at least some years.
A remark on the copyright for debien/*: You've choosen
a different license here than the upstream license. This
is of course your choice, but if the license differ this could
make it difficult to include stuff (like patches) to upstream,
as GPL-3 and unlicense are not compatible in the GPL…
As you are the only person working on the package and upstream,
that be easily fixed by relicensing the debian directory to
unlicense as well…
I did not realise is was permissible to license debian/* anything other
than a GPL license. Will fix in the next release.
- There are a lots of tests skipped due to missing xmllint…
Is there a missing B-D on libxml2-utils?
The test suite for this package is pretty long running, even without the
XML tests, and I didn't think they were critical (it's pretty hard to
break this functionality without the problem being obvious upstream
first). I can certainly add libxml2-utils to enable them though if you
think it's advisable. Another optional thing is the presence of an SMT
solver like Z3 which would enable some other optional tests.
Those are not critcial issues, but please consider them for later
revisions of your package. So I'm going to upload your package soon.
Thanks for your contribution to Debian!
