Hi,
On 2022/01/10 17:49, Ko Ko Ye` wrote:
Dear Kyle and other Debian Mentors and Sponsors
please kindly check again for ibus-keymagic
[1] https://keymagic.net
[2] https://github.com/thantthet/keymagic-keyboards
[3] https://mentors.debian.net/package/ibus-keymagic
[4] https://www.youtube.com/playlist?list=PL1EDkyTdWxl5RKymdn9wdNvZ6ADKtUmcQ
BR
On Thu, May 28, 2020, 2:54 PM Kyle Robbertze
<paddatrap...@debian.org <mailto:paddatrap...@debian.org>> wrote:
Control: tags -1 moreinfo
Hi,
After reviewing the package, there are a couple things I noticed:
- Missing copyright info for the following files:
* ./m4/*
* ./INSTALL
* ./aclocal.m4
* ./config.rpath
* ./install-sh
- The watch file is broken - it points to your packaging repo.
It should
use the upstream launchpad repo
- The changelog should only have 'Initial packaging (Closes:
#933071)'
as the change list. The other change lines are not needed.
- The package builds a lot of binary packages with 1 file each.
Is this
necessary? Consider combining everything into one or two packages
Cheers
Kyle
--
All of these still apply. Also you can drop the ~exp1 in the version
number, as you are targeting unstable, not experimental.
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze
