Hi Lance,

The filenamemangle in the debian/watch file is not correct. Please test it with 
uscan.

Please consider relicensing debian/* or at least debian/patches/* to the same license as upstream (Apache 2). The problem with the debian/* license being more restrictive than upstream is that your patches cannot be used by upstream and you might exclude possible reverse dependencies from using the Debian package.

You reference the non-existing https://salsa.debian.org/debian/workflow.
If you want to maintain your package there, I can create that repository for 
you on sponsoring.
Else, please remove the references.

You can include the cmake files in the -dev package if there are no problems 
with them.

There are missing copyright notices and BSD licenses in src/util/crc32c.*

Please fix lintian's duplicate-short-description and 
debian-rules-uses-as-needed-linker-flag.

You should not need to build depend on dh-exec with debhelper 13.

Cheers,
Bastian

Reply via email to