On 23.12.2020 14:22, Adam Borowski wrote:
On Wed, Dec 23, 2020 at 02:07:44PM +0100, Gürkan Myczko wrote:
> Also, why would the package go into non-free?
Because if not:
https://github.com/elfmz/far2l/issues/692
https://lintian.debian.org/tags/license-problem-convert-utf-code.html
And I should fix missing-explanation-for-contrib-or-non-free-package.
Then it's incompatible with GPL2, and can't go into the archive anyway.
Is this just this single file that's bad? I've written UTF8<->16<->32
conversions by hand a number of times, and so did other folks. This
isn't
exactly functionality that's hard to come by.
As far as I can tell, yes:
$ find . -name "ConvertUTF*"
./utils/include/ConvertUTF.h
./utils/src/ConvertUTF.c
$ grep -ri "ConvertUTF.h" |grep -v obj-x86
WinPort/src/APIStringCodepages.cpp:#include "ConvertUTF.h"
WinPort/src/Backend/TTY/TTYFar2lClipboardBackend.cpp:#include
<ConvertUTF.h>
WinPort/src/Backend/TTY/TTYInput.cpp:#include "ConvertUTF.h"
WinPort/src/Backend/TTY/TTYInputSequenceParser.cpp:#include
"ConvertUTF.h"
WinPort/src/Backend/TTY/TTYOutput.cpp:#include "ConvertUTF.h"
WinPort/src/Backend/WX/Paint.cpp:#include <ConvertUTF.h>
far2l/VTFar2lExtensios.cpp:#include <ConvertUTF.h>
far2l/viewer.cpp:#include "../utils/include/ConvertUTF.h"
utils/include/ConvertUTF.h:/*===--- ConvertUTF.h - Universal Character
Names conversions ---------------===
utils/include/ConvertUTF.h:#ifndef CLANG_BASIC_CONVERTUTF_H
utils/include/ConvertUTF.h:#define CLANG_BASIC_CONVERTUTF_H
utils/src/ConvertUTF.c: See the header file "ConvertUTF.h" for
complete documentation.
utils/src/ConvertUTF.c:#include "ConvertUTF.h"
utils/src/InMy.cpp:#include "ConvertUTF.h"
utils/src/InstallPath.cpp:#include "ConvertUTF.h"
utils/src/utils.cpp:#include "ConvertUTF.h"
I've also found some other packages that replaced it with
ICUsomething... but then thought meh.
I'm going for the low hanging fruits, freeze is soon.
喵!