On Tue, Feb 17, 2004 at 01:54:57AM -0500, Rudy Godoy wrote: > Hi there, as i've said before [0] I'm willing to adpot xhangglider, I've > worked on the package and I've finally uploaded [1] to mentors.debian.net. > If there's anybody who wants to sponsor this package I'll appreciate to take > a look on it and let me know.
This doesn't look too much different from the old package... 1) You should work the build system so that the binary and manpage are built in the build-stamp target. 2) You should remove Makefile from the orig.tar.gz in the clean target at some point and upload a new one. Currently, refreshing the Makefile that came in the orig.tar.gz causes major diff.gz bloat: $ zcat ../*.diff.gz | diffstat Imakefile | 6 Makefile | 552 ++++++++++++++++++++++++++++++++------------ debian/README.Debian | 5 debian/changelog | 57 ++++ debian/compat | 1 debian/control | 14 + debian/copyright | 19 + debian/dirs | 3 debian/docs | 4 debian/menu | 4 debian/rules | 65 +++++ debian/xhangglider.1 | 36 ++ debian/xhangglider.1x | 36 ++ debian/xhangglider.es.1 | 39 +++ debian/xhangglider.manpages | 1 glider.def | 4 16 files changed, 694 insertions(+), 152 deletions(-) Or you could move it away at build time and move it back later. 3) It is probably desirable to support DEB_BUILD_OPTIONS=noopt in your debian/rules, so that the binary is built at -O0 instead of -O2 (i.e. for debugging purposes.) Otherwise this looks pretty nice. I took a look at the bugs page for xhangglider and posted a patch to #192923 - seems to work and you should apply it I think. -- Joshua Kwan
signature.asc
Description: Digital signature
